Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-6816] - Add AGLB Create Route Drawer #9806

Merged
merged 11 commits into from
Oct 19, 2023
Merged

feat: [M3-6816] - Add AGLB Create Route Drawer #9806

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b2cae85
Work In Progress
jaalah Oct 16, 2023
7510384
Update latest
jaalah Oct 17, 2023
66af649
Add cypress tests
jaalah Oct 17, 2023
1bcefbe
Rename desc
jaalah Oct 17, 2023
4dee326
Remove it.only
jaalah Oct 17, 2023
6e3750f
Added changeset: Add AGLB Create Route Drawer
jaalah Oct 17, 2023
306c444
Update packages/manager/cypress/support/intercepts/load-balancers.ts
jaalah-akamai Oct 19, 2023
42018f0
Merge branch 'develop' of github.com:linode/manager into M3-6816
jaalah Oct 19, 2023
be62eca
Merge branch 'M3-6816' of github.com:jaalah-akamai/manager into M3-6816
jaalah Oct 19, 2023
336200e
Update formik error handling
jaalah Oct 19, 2023
a8a3032
Update changesets
jaalah Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/CreateRouteDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { CreateRoutePayload } from '@linode/api-v4';
import { useTheme } from '@mui/material/styles';
import { useFormik } from 'formik';
import React from 'react';

Expand All @@ -13,7 +12,9 @@ import { Radio } from 'src/components/Radio/Radio';
import { RadioGroup } from 'src/components/RadioGroup';
import { TextField } from 'src/components/TextField';
import { useLoadBalancerRouteCreateMutation } from 'src/queries/aglb/routes';
import scrollErrorIntoView from 'src/utilities/scrollErrorIntoView';
import { capitalize } from 'src/utilities/capitalize';
import { getFormikErrorsFromAPIErrors } from 'src/utilities/formikErrorUtils';
import { scrollErrorIntoView } from 'src/utilities/scrollErrorIntoView';

interface Props {
loadbalancerId: number;
Expand All @@ -28,7 +29,6 @@ const initialValues: CreateRoutePayload = {
};

export const CreateRouteDrawer = (props: Props) => {
const theme = useTheme();
const { loadbalancerId, onClose: _onClose, open } = props;

const {
Expand All @@ -43,8 +43,9 @@ export const CreateRouteDrawer = (props: Props) => {
try {
await createRoute(values);
onClose();
} catch (error) {
} catch (errors) {
scrollErrorIntoView();
formik.setErrors(getFormikErrorsFromAPIErrors(errors));
}
},
});
Expand All @@ -62,7 +63,7 @@ export const CreateRouteDrawer = (props: Props) => {
<form onSubmit={formik.handleSubmit}>
{generalError && <Notice text={generalError} variant="error" />}
<TextField
errorText={error?.find((e) => e.field === 'label')?.reason}
errorText={formik.touched.label ? formik.errors.label : undefined}
label="Route Label"
name="label"
onChange={formik.handleChange}
Expand All @@ -72,7 +73,9 @@ export const CreateRouteDrawer = (props: Props) => {
onChange={(_, value) => formik.setFieldValue('protocol', value)}
value={formik.values.protocol}
>
<FormLabel sx={{ marginTop: theme.spacing(1) }}>Protocol</FormLabel>
<FormLabel sx={(theme) => ({ marginTop: theme.spacing(1) })}>
Protocol
</FormLabel>
<FormControlLabel
control={<Radio />}
data-qa-radio={'HTTP'}
Expand All @@ -85,8 +88,12 @@ export const CreateRouteDrawer = (props: Props) => {
label="TCP"
value="tcp"
/>
<FormHelperText>
{error?.find((e) => e.field === 'protocol')?.reason}
<FormHelperText error>
{formik.touched.protocol
? typeof formik.errors.protocol === 'string'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to narrow this type because it returned string | undefined and capitalize doesn't like that.

? capitalize(formik.errors.protocol)
: undefined
: undefined}
</FormHelperText>
</RadioGroup>
<ActionsPanel
Expand Down