-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-7183] - Handle Managed test acccounts in Linode Backup tests #9809
test: [M3-7183] - Handle Managed test acccounts in Linode Backup tests #9809
Conversation
* | ||
* @param state - Cypress internal state to retrieve. | ||
*/ | ||
state(state: string): any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of crazy that Cypress does not expose a type for this. I tried looking for one but didn't find anything notable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joe! Confirmed the following:
✅ Can enable backups test is skipped
✅ when running with CY_TEST_FAIL_ON_MANAGED=1, 'can enable backups' test fails
Description 📝
This allows the Cypress backup tests to more gracefully handle cases where the test account has Managed.
CY_TEST_FAIL_ON_MANAGED
environment variable is defined, the tests will fail instead. This is intended for CI environments where Managed should never be enabled on test accounts.See this discussion for more context: #9699 (review)
Changes 🔄
CY_TEST_FAIL_ON_MANAGED
environment variable to control test behavior on Managed accountsHow to test 🧪
Prerequisites
yarn && yarn build && yarn start:manager:ci
Verification steps
yarn cy:run -s "cypress/e2e/core/linodes/backup-linode.spec.ts"
and confirm that the "can enable backups" test is skipped and the rest of the tests passCY_TEST_FAIL_ON_MANAGED=1 yarn cy:run -s "cypress/e2e/core/linodes/backup-linode.spec.ts"
and confirm that the "can enable backups" test fails and the rest of the tests passAs an Author I have considered 🤔
Check all that apply