Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [M3-7253] - Add AGLB details - Configurations - Routes Table #9811

Merged
merged 9 commits into from
Oct 24, 2023
Merged

feat: [M3-7253] - Add AGLB details - Configurations - Routes Table #9811

merged 9 commits into from
Oct 24, 2023

Conversation

cpathipa
Copy link
Contributor

@cpathipa cpathipa commented Oct 18, 2023 •
edited
Loading

Description 📝

Add AGLB details - Configurations - Routes Table

Before After
image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • Checkout the branch and run the app locally
  • Enable MSW

Verification steps

(How to verify changes)

As an Author I have considered 🤔

Check all that apply

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@cpathipa cpathipa requested a review from a team as a code owner October 18, 2023 12:11
@cpathipa cpathipa requested review from jdamore-linode and coliu-akamai and removed request for a team October 18, 2023 12:11
@cpathipa cpathipa marked this pull request as draft October 18, 2023 12:11
@cpathipa cpathipa self-assigned this Oct 18, 2023
@cpathipa cpathipa added ACLB Relating to the Akamai Cloud Load Balancer Work in Progress labels Oct 18, 2023
@cpathipa cpathipa marked this pull request as ready for review October 19, 2023 13:38
bnussman-akamai
bnussman-akamai approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@bnussman-akamai bnussman-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks great!

packages/manager/src/features/LoadBalancers/LoadBalancerDetail/Routes/RoutesTable.tsx Outdated Show resolved Hide resolved
coliu-akamai
coliu-akamai approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 great work!

  • Confirmed expandable Routes Table in Configurations Tab ✅
  • confirmed expandable Routes Table in Routes Tab ✅

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Oct 23, 2023
cpathipa and others added 2 commits October 24, 2023 10:48
@cpathipa @bnussman-akamai
Update packages/manager/src/features/LoadBalancers/LoadBalancerDetail…
e6dc3a5 
…/Routes/RoutesTable.tsx

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
@cpathipa
PR - Feedback
d27accb
@cpathipa cpathipa merged commit 4a63694 into linode:develop Oct 24, 2023
10 of 11 checks passed
@cpathipa cpathipa deleted the M3-7253 branch October 24, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliu-akamai coliu-akamai coliu-akamai approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@jdamore-linode jdamore-linode Awaiting requested review from jdamore-linode jdamore-linode is a code owner automatically assigned from linode/frontend

Assignees

@cpathipa cpathipa

Labels
ACLB Relating to the Akamai Cloud Load Balancer Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpathipa @bnussman-akamai @coliu-akamai