Release v1.106.0 - release → staging

.github/workflows/e2e_schedule_and_push.yml

@@ -6,6 +6,7 @@ env:
   USER_3: ${{ secrets.USER_3 }}
   USER_4: ${{ secrets.USER_4 }}
   CLIENT_ID: ${{ secrets.REACT_APP_CLIENT_ID }}
+  CY_TEST_FAIL_ON_MANAGED: 1
 on:
   schedule:
     - cron: "0 13 * * 1-5"

docs/development-guide/02-component-structure.md

@@ -7,59 +7,74 @@ The basic structure of a component file should follow:
 ```
 [ imports ]
 [ types and interfaces ]
-[ function component definition ]
-[ styles ]
-[ utility functions ]
-[ default export ]
+[ exported function component definition ]
+[ styles ] (possibly in their own file)
+[ utility functions ] (possibly in their own file)
 ```
 
 Here is a minimal code example demonstrating the basic structure of a component file:
 
 ```tsx
 import * as React from "react";
 import { styled } from "@mui/material/styles";
-import { isPropValid } from "src/utilities/isPropValid";
+import { omittedProps } from "src/utilities/omittedProps";
 
-interface SayHelloProps {
+// If not exported, it can just be named `Props`
+export interface SayHelloProps {
   name: string;
   isDisabled: boolean;
 }
 
-const SayHello = (props: SayHelloProps) => {
+export const SayHello = (props: SayHelloProps) => {
   const { name, isDisabled } = props;
 
   return <StyledH1 isDisabled={isDisabled}>Hello, {capitalize(name)}</StyledH1>;
 };
 
+/**
+ * Should be moved to SayHello.styles.ts if component was large (> 100 lines).
+*/
 const StyledH1 = styled("h1", {
   label: "StyledH1",
-  shouldForwardProp: (prop) => isPropValid(["isDisabled"], prop),
+  shouldForwardProp:  omittedProps(["isDisabled"]),
 })(({ theme, ...props }) => ({
   color: props.isDisabled ? theme.color.grey : theme.color.black,
 }));
 
+/**
+* It's often a good idea to move utilities to their own files as well,
+* either in the `src/utilities` directory if meant to be portable and reusable,
+* or in the feature's directory as a .utils.ts file. ex: `SayHello.utils.ts`.
+* Isolation makes utils easier to test and reduces the main file size for better readability.
+* Doing so also may also reveal the use case is already covered by an existing utility.
+*/
 export const capitalize = (s: string) => {
   return s.charAt(0).toUpperCase() + s.slice(1);
 };
-
-export { SayHello };
 ```
 
-- There are cases where you don't want the prop to be forwarded to the DOM element, so we've provided a helper `isPropValid` to assist in these cases.
-- The `label` property in the `styled` API is used to provide a unique identifier for the component when it is being styled. This can be useful when debugging a large codebase, as it can help identify which component the style is being applied to. For example, if you have multiple instances of the `StyledH1` component, the `label` property can help you identify which instance is being styled in the browser's developer tools.
-
 #### Imports
 
 - Import React with `import * as React from 'react'`.
 - Use absolute imports, e.g. `import { queryClient } from 'src/queries/base'`.
 - Methods from the api-v4 package should be imported from `@linode/api-v4/lib/..`.
 
+#### Composition
+
+When building a large component, it is recommended to break it down and avoid writing several components within the same file. It improves readability and testability. Components should, in most cases, come with their own unit test, although they can be skipped if an e2e suite is covering the functionality.
+Utilities should almost always feature a unit test.
+
 #### Styles
 
 - With the transition to MUI v5, the [`styled`](https://mui.com/system/styled/) API, along with the [`sx` prop](https://mui.com/system/getting-started/the-sx-prop/), is the preferred way to specify component-specific styles.
-  - Component-specific styles may be defined at the end of the component file or in a dedicated file, named `ComponentName.styles.tsx`.
+  - Component-specific styles may be defined at the end of the component file or in a dedicated file, named `ComponentName.styles.ts`.
   - Component files longer than 100 lines must have these styles defined in a dedicated file.
 
+##### Styled Components
+- The `label` property in the `styled` API is used to provide a unique identifier for the component when it is being styled. This can be useful when debugging a large codebase, as it can help identify which component the style is being applied to. For example, if you have multiple instances of the `StyledH1` component, the `label` property can help you identify which instance is being styled in the browser's developer tools.
+- There are cases where you don't want the prop to be forwarded to the DOM element, so we've provided a helper `omittedProps` to assist in these cases.
+It is the responsibility of the developer to check for any console error in case non-semantic props make their way to the dom.
+
 #### Types and Interfaces
 
 - To specify component props, define an interface with the name of the component `MyComponentProps` and pass it to the component as a type argument. This is to provide clarity if ever we need to export this type into another component.

docs/development-guide/08-testing.md

@@ -211,6 +211,7 @@ Environment variables related to Cypress logging and reporting, as well as repor
 | `CY_TEST_USER_REPORT`           | Log test account information when tests begin | `1`       | Unset; disabled by default |
 | `CY_TEST_JUNIT_REPORT`          | Enable JUnit reporting                        | `1`       | Unset; disabled by default |
 | `CY_TEST_DISABLE_FILE_WATCHING` | Disable file watching in Cypress UI           | `1`       | Unset; disabled by default |
+| `CY_TEST_FAIL_ON_MANAGED`       | Fail affected tests when Managed is enabled   | `1`       | Unset; disabled by default |
 
 ### Writing End-to-End Tests
 

packages/api-v4/.changeset/pr-9800-upcoming-features-1698173062924.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Upcoming Features
+---
+
+Update schema and request method of `updateLoadbalancerServiceTarget` ([#9800](https://github.com/linode/manager/pull/9800))

packages/api-v4/.changeset/pr-9806-upcoming-features-1697723638782.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Upcoming Features
+---
+
+Updated AGLB createLoadbalancerRoute endpoint with payload/schema ([#9806](https://github.com/linode/manager/pull/9806))

packages/api-v4/.changeset/pr-9824-upcoming-features-1697827003419.md

@@ -0,0 +1,5 @@
+---
+"@linode/api-v4": Upcoming Features
+---
+
+Update the `Subnet` and `Interface` interfaces to match new API spec ([#9824](https://github.com/linode/manager/pull/9824))

packages/api-v4/src/account/types.ts

@@ -8,6 +8,27 @@ export interface User {
   ssh_keys: string[];
   tfa_enabled: boolean;
   verified_phone_number: string | null;
+  /**
+   * The date of when a password was set on a user.
+   * `null` if this user has not created a password yet
+   * @example 2022-02-09T16:19:26
+   * @example null
+   */
+  password_created: string | null;
+  /**
+   * Information for the most recent login attempt for this User.
+   * `null` if no login attempts have been made since creation of this User.
+   */
+  last_login: {
+    /**
+     * @example 2022-02-09T16:19:26
+     */
+    login_datetime: string;
+    /**
+     * @example successful
+     */
+    status: AccountLoginStatus;
+  } | null;
 }
 
 export interface Account {

packages/api-v4/src/aglb/routes.ts

@@ -7,8 +7,8 @@ import Request, {
 } from '../request';
 import { Filter, Params, ResourcePage } from '../types';
 import { BETA_API_ROOT } from '../constants';
-import type { Route, RoutePayload, UpdateRoutePayload } from './types';
-import { UpdateRouteSchema } from '@linode/validation';
+import type { Route, CreateRoutePayload, UpdateRoutePayload } from './types';
+import { UpdateRouteSchema, CreateRouteSchema } from '@linode/validation';
 
 /**
  * getLoadbalancerRoutes
@@ -51,13 +51,13 @@ export const getLoadbalancerRoute = (loadbalancerId: number, routeId: number) =>
  */
 export const createLoadbalancerRoute = (
   loadbalancerId: number,
-  data: RoutePayload
+  data: CreateRoutePayload
 ) =>
   Request<Route>(
     setURL(
       `${BETA_API_ROOT}/aglb/${encodeURIComponent(loadbalancerId)}/routes`
     ),
-    setData(data),
+    setData(data, CreateRouteSchema),
     setMethod('POST')
   );
 

packages/api-v4/src/aglb/service-targets.ts

@@ -8,7 +8,10 @@ import Request, {
 import { Filter, Params, ResourcePage } from '../types';
 import { BETA_API_ROOT } from '../constants';
 import type { ServiceTarget, ServiceTargetPayload } from './types';
-import { CreateServiceTargetSchema } from '@linode/validation';
+import {
+  CreateServiceTargetSchema,
+  UpdateServiceTargetSchema,
+} from '@linode/validation';
 
 /**
  * getLoadbalancerServiceTargets
@@ -84,8 +87,8 @@ export const updateLoadbalancerServiceTarget = (
         loadbalancerId
       )}/service-targets/${encodeURIComponent(serviceTargetId)}`
     ),
-    setData(data),
-    setMethod('POST')
+    setData(data, UpdateServiceTargetSchema),
+    setMethod('PUT')
   );
 
 /**

packages/api-v4/src/linodes/types.ts

@@ -165,14 +165,15 @@ export interface Interface {
   purpose: InterfacePurpose;
   ipam_address: string | null;
   primary?: boolean;
+  active: boolean;
   subnet_id?: number | null;
   vpc_id?: number | null;
   ipv4?: ConfigInterfaceIPv4;
   ipv6?: ConfigInterfaceIPv6;
   ip_ranges?: string[];
 }
 
-export type InterfacePayload = Omit<Interface, 'id'>;
+export type InterfacePayload = Omit<Interface, 'id' | 'active'>;
 
 export interface ConfigInterfaceOrderPayload {
   ids: number[];

packages/api-v4/src/regions/types.ts

@@ -5,6 +5,7 @@ export type Capabilities =
   | 'GPU Linodes'
   | 'Kubernetes'
   | 'Linodes'
+  | 'Managed Databases'
   | 'Metadata'
   | 'NodeBalancers'
   | 'Object Storage'

packages/api-v4/src/vpcs/types.ts

@@ -1,3 +1,5 @@
+import { Interface } from 'src/linodes';
+
 export interface VPC {
   id: number;
   label: string;
@@ -28,11 +30,18 @@ export interface CreateSubnetPayload {
 
 export interface Subnet extends CreateSubnetPayload {
   id: number;
-  linodes: number[];
+  linodes: SubnetAssignedLinodeData[];
   created: string;
   updated: string;
 }
 
 export interface ModifySubnetPayload {
   label: string;
 }
+
+export type SubnetLinodeInterfaceData = Pick<Interface, 'active' | 'id'>;
+
+export interface SubnetAssignedLinodeData {
+  id: number;
+  interfaces: SubnetLinodeInterfaceData[];
+}

packages/manager/.changeset/pr-9660-added-1697473425862.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Added
+---
+
+Dynamic price error handling for DC-specific pricing ([#9660](https://github.com/linode/manager/pull/9660))

packages/manager/.changeset/pr-9709-upcoming-features-1697141846298.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Support VPCs in Add/Edit Linode Config dialog ([#9709](https://github.com/linode/manager/pull/9709))

packages/manager/.changeset/pr-9748-tech-stories-1696350216805.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+MUI v5 Migration - Src > Features > Users ([#9748](https://github.com/linode/manager/pull/9748))

packages/manager/.changeset/pr-9754-tech-stories-1696437177982.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+Migrate NodeBalancer Node Mode Select TextField to Autocomplete ([#9754](https://github.com/linode/manager/pull/9754))

packages/manager/.changeset/pr-9756-tech-stories-1696441475265.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+Migrate UserDefinedSelect from a TextField Select to an Autocomplete ([#9756](https://github.com/linode/manager/pull/9756))

packages/manager/.changeset/pr-9771-added-1698247004747.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Added
+---
+
+October Marketplace apps ([#9771](https://github.com/linode/manager/pull/9771))

packages/manager/.changeset/pr-9773-tech-stories-1696952796931.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+MUI v5 Migration - `SRC > Features > StackScripts` pt1 ([#9773](https://github.com/linode/manager/pull/9773))

packages/manager/.changeset/pr-9777-tests-1696958372039.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Improve error message display when Linode API error occurs in Cypress test ([#9777](https://github.com/linode/manager/pull/9777))

packages/manager/.changeset/pr-9778-upcoming-features-1696961231870.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Add AGLB Routes - Rule Edit Drawer  ([#9778](https://github.com/linode/manager/pull/9778))

packages/manager/.changeset/pr-9781-tests-1697144294347.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Improve Linode config edit test stability ([#9781](https://github.com/linode/manager/pull/9781))

packages/manager/.changeset/pr-9782-tests-1697147463647.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Improve LKE create test reattempt stability ([#9782](https://github.com/linode/manager/pull/9782))

packages/manager/.changeset/pr-9783-tech-stories-1697046190232.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+Clean up `src/utilities` exports ([#9783](https://github.com/linode/manager/pull/9783))

packages/manager/.changeset/pr-9784-tests-1697487553929.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Clean up Jest warnings and errors ([#9784](https://github.com/linode/manager/pull/9784))

packages/manager/.changeset/pr-9785-fixed-1697059201989.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+Firewall Create Drawer opens in the same tab in the Linode Create Flow ([#9785](https://github.com/linode/manager/pull/9785))

packages/manager/.changeset/pr-9786-tech-stories-1697120258125.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+MUI v5 Migration - `SRC > Features > StackScripts` pt 2 ([#9786](https://github.com/linode/manager/pull/9786))

packages/manager/.changeset/pr-9787-upcoming-features-1697145963212.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Only show regions that support VPCs in VPC Create page ([#9787](https://github.com/linode/manager/pull/9787))

packages/manager/.changeset/pr-9788-changed-1697134985443.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Changed
+---
+
+Improve Linode Create Error Placement ([#9788](https://github.com/linode/manager/pull/9788))

packages/manager/.changeset/pr-9790-changed-1697132255387.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Changed
+---
+
+Rename isPropValid utility ([#9790](https://github.com/linode/manager/pull/9790))

packages/manager/.changeset/pr-9791-fixed-1697461463011.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Fixed
+---
+
+Quote variable in changeset shell command ([#9791](https://github.com/linode/manager/pull/9791))

packages/manager/.changeset/pr-9800-upcoming-features-1698173161683.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Add AGLB Edit Service Target drawer ([#9800](https://github.com/linode/manager/pull/9800))

packages/manager/.changeset/pr-9801-tests-1697547109194.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Fix DBaaS UI test failures stemming from API update ([#9801](https://github.com/linode/manager/pull/9801))

packages/manager/.changeset/pr-9804-upcoming-features-1697563268544.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Add AGLB Rule Delete Dialog ([#9804](https://github.com/linode/manager/pull/9804))

packages/manager/.changeset/pr-9806-upcoming-features-1697563902060.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Upcoming Features
+---
+
+Add AGLB Create Route Drawer ([#9806](https://github.com/linode/manager/pull/9806))

packages/manager/.changeset/pr-9807-tests-1697570775779.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tests
+---
+
+Refactor Cypress Firewall migration tests ([#9807](https://github.com/linode/manager/pull/9807))