feat: [M3-7311] - Create Load Balancer flow - manage state #9848

cpathipa · 2023-10-30T13:42:46Z

Description 📝

Create Load Balancer flow - Manage state.

How to test 🧪

Prerequisites

(How to setup test environment)

Checkout the branch and run the app locally
Enable MSW

Verification steps

(How to verify changes)

Navigate to http://localhost:3000/loadbalancers
Click on "Create Load Balancer" Button.
Verify Load Balancer label field state.
Verify Create LoadBalancer payload schema W.R.T API spec.
Verify tests for LoadBalancerLabel.test.tsx.

As an Author I have considered 🤔

Check all that apply

cpathipa · 2023-10-30T13:45:25Z

packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerCreate.tsx

-        <LoadBalancerLabel
-          labelFieldProps={{
-            disabled: false,
-            errorText: '',
-            label: 'Linode Label',
-            onChange: () => null,
-            value: '',
-          }}


Prop drilling is not required since we use a ~~custom state management hook useLoadBalancerState~~ useFormikContext.

packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerRegions.tsx

packages/manager/src/features/LoadBalancers/useLoadBalancerState.ts

packages/validation/src/loadbalancers.schema.ts

packages/manager/.changeset/pr-9848-upcoming-features-1698675578462.md

…78462.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerCreate.tsx

packages/validation/src/loadbalancers.schema.ts

packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerCreate.tsx

packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerActionPanel.tsx

packages/validation/src/loadbalancers.schema.ts

mjac0bs · 2023-11-01T16:59:55Z

packages/manager/cypress/e2e/core/databases/update-database.spec.ts

Unrelated linter change that snuck in.

packages/validation/src/loadbalancers.schema.ts

mjac0bs · 2023-11-01T17:59:05Z

I'm also encountering an unexpected validation error on the label field when I enter something valid and hit the Review Load Balancer button. Are you seeing the same?

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com>

cpathipa · 2023-11-01T21:07:07Z

@mjac0bs This issue is fixed now.

AGLB-statemanagement.mov

cpathipa · 2023-11-01T21:38:00Z

@mjac0bs Updated the endpointSchema as per the API spec (a4dcb76).

mjac0bs

Thanks for fixing the label validation!

There's an issue with the endpoint validation that I commented on and an inconsistency in the API spec we'll want to double check.

My other suggestions are optional and just to use a consistent naming scheme for all our loadbalancer schemas.

packages/validation/src/loadbalancers.schema.ts

packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerCreate.tsx

This reverts commit 106f4d1.

mjac0bs

Thanks for following up with API!

Tests and validation looks good now with the resolved dependency. I think we're just missing a changeset for the validation package.

packages/validation/src/loadbalancers.schema.ts

feat: [M3-7311] - Create Load Balancer flow - Mange state.

f7bcbb9

cpathipa requested a review from a team as a code owner October 30, 2023 13:42

cpathipa requested review from jdamore-linode and coliu-akamai and removed request for a team October 30, 2023 13:42

cpathipa marked this pull request as draft October 30, 2023 13:42

cpathipa commented Oct 30, 2023

View reviewed changes

Code cleanup

3f38d91

cpathipa commented Oct 30, 2023

View reviewed changes

Added changeset: Create Load Balancer flow - Mange state.

775bb86

cpathipa changed the title ~~feat: [M3-7311] - Create Load Balancer flow - Mange state.~~ feat: [M3-7311] - Create Load Balancer flow - Manage state. Oct 30, 2023

Update pr-9848-upcoming-features-1698675578462.md

af5fd8a

cpathipa marked this pull request as ready for review October 30, 2023 14:21

cpathipa self-assigned this Oct 30, 2023

cpathipa added the ACLB Relating to the Akamai Cloud Load Balancer label Oct 30, 2023

Merge remote-tracking branch 'origin/develop' into M3-7311

69488c2

mjac0bs reviewed Oct 30, 2023

View reviewed changes

packages/manager/.changeset/pr-9848-upcoming-features-1698675578462.md Outdated Show resolved Hide resolved

Update update-database.spec.ts

266d259

mjac0bs changed the title ~~feat: [M3-7311] - Create Load Balancer flow - Manage state.~~ feat: [M3-7311] - Create Load Balancer flow - manage state Oct 30, 2023

cpathipa and others added 2 commits October 30, 2023 14:45

Update packages/manager/.changeset/pr-9848-upcoming-features-16986755…

44027c9

…78462.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

Fix typos

e0ea1ba

cpathipa requested review from bnussman-akamai and mjac0bs October 30, 2023 21:18

use useFormikContext instead of custom state management hook

28df367

bnussman-akamai reviewed Nov 1, 2023

View reviewed changes

packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerCreate.tsx Outdated Show resolved Hide resolved

packages/validation/src/loadbalancers.schema.ts Outdated Show resolved Hide resolved

PR feedback

59b3534

cpathipa requested a review from bnussman-akamai November 1, 2023 14:25

Merge remote-tracking branch 'origin/develop' into M3-7311

994a104

bnussman-akamai approved these changes Nov 1, 2023

View reviewed changes

packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerCreate.tsx Show resolved Hide resolved

packages/manager/src/features/LoadBalancers/LoadBalancerCreate/LoadBalancerActionPanel.tsx Show resolved Hide resolved

cpathipa added the Add'tl Approval Needed Waiting on another approval! label Nov 1, 2023

jdamore-linode reviewed Nov 1, 2023

View reviewed changes

packages/validation/src/loadbalancers.schema.ts Outdated Show resolved Hide resolved

mjac0bs reviewed Nov 1, 2023

View reviewed changes

cpathipa and others added 3 commits November 1, 2023 15:58

Update loadbalancers.schema.ts

f92709a

Update packages/validation/src/loadbalancers.schema.ts

2d1a7e0

Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>

Update packages/validation/src/loadbalancers.schema.ts

2791bc3

Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com>

cpathipa added 2 commits November 1, 2023 16:35

Update loadbalancers.schema.ts

a4dcb76

Merge branch 'M3-7311' of github.com:cpathipa/manager into M3-7311

5a547bf

cpathipa requested review from mjac0bs and jdamore-linode November 1, 2023 21:38

mjac0bs reviewed Nov 2, 2023

View reviewed changes

cpathipa added 3 commits November 2, 2023 10:21

Update CreateLoadBalancerSchema and Endpoint Schema

106f4d1

Revert "Update CreateLoadBalancerSchema and Endpoint Schema"

e5109b5

This reverts commit 106f4d1.

Code cleanup and update Endpoint schema.

69c3038

cpathipa requested a review from mjac0bs November 2, 2023 15:52

mjac0bs approved these changes Nov 2, 2023

View reviewed changes

packages/validation/src/loadbalancers.schema.ts Show resolved Hide resolved

mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Nov 2, 2023

mjac0bs reviewed Nov 2, 2023

View reviewed changes

packages/validation/src/loadbalancers.schema.ts Outdated Show resolved Hide resolved

cpathipa added 2 commits November 2, 2023 12:07

Update the field names

1468860

Added changeset: Create Load Balancer flow - manage state

d08dfb9

cpathipa merged commit 3ea7090 into linode:develop Nov 2, 2023
11 checks passed

cpathipa deleted the M3-7311 branch November 2, 2023 17:21

This was referenced Nov 8, 2023

Release v1.107.0 - release → staging #9889

Merged

Release v1.107.0 - staging → master #9898

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-7311] - Create Load Balancer flow - manage state #9848

feat: [M3-7311] - Create Load Balancer flow - manage state #9848

cpathipa commented Oct 30, 2023 •

edited

Loading

cpathipa Oct 30, 2023 •

edited

Loading

mjac0bs Nov 1, 2023

mjac0bs commented Nov 1, 2023 •

edited

Loading

cpathipa commented Nov 1, 2023

cpathipa commented Nov 1, 2023

mjac0bs left a comment •

edited

Loading

mjac0bs left a comment

feat: [M3-7311] - Create Load Balancer flow - manage state #9848

feat: [M3-7311] - Create Load Balancer flow - manage state #9848

Conversation

cpathipa commented Oct 30, 2023 • edited Loading

Description 📝

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

cpathipa Oct 30, 2023 • edited Loading

Choose a reason for hiding this comment

mjac0bs Nov 1, 2023

Choose a reason for hiding this comment

mjac0bs commented Nov 1, 2023 • edited Loading

cpathipa commented Nov 1, 2023

cpathipa commented Nov 1, 2023

mjac0bs left a comment • edited Loading

Choose a reason for hiding this comment

mjac0bs left a comment

Choose a reason for hiding this comment

cpathipa commented Oct 30, 2023 •

edited

Loading

cpathipa Oct 30, 2023 •

edited

Loading

mjac0bs commented Nov 1, 2023 •

edited

Loading

mjac0bs left a comment •

edited

Loading