Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change: [OCA-1240] - Update Main Concept app names to include demo #9950

Merged
merged 9 commits into from
Dec 7, 2023
Merged

change: [OCA-1240] - Update Main Concept app names to include demo #9950

merged 9 commits into from
Dec 7, 2023

Conversation

tbaka-akamai
Copy link
Contributor

Description 📝

Updates app names to highlight deployments are demos.

Changes 🔄

updates stasckscript.utils
updates oneClickApps.ts

@tbaka-akamai tbaka-akamai requested a review from a team as a code owner December 1, 2023 15:07
@tbaka-akamai tbaka-akamai requested review from bnussman-akamai and tyler-akamai and removed request for a team December 1, 2023 15:07
@tyler-akamai
Copy link
Contributor

tyler-akamai commented Dec 4, 2023 •
edited
Loading

make sure to add changeset:

@hana-akamai hana-akamai changed the title [OCA-1240] Change/main concept demos change: [OCA-1240] - Update Main Concept app names to include demo Dec 6, 2023
@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 6, 2023
@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 6, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Coverage Report: ✅
Base Coverage: 86.51%
Current Coverage: 86.51%

mjac0bs
mjac0bs approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Confirmed that all the MainConcept app names display 'Demo' and all the drawers open and display correctly on this branch.

🚀

@hana-akamai hana-akamai merged commit ed841e7 into linode:develop Dec 7, 2023
13 of 15 checks passed
@mjac0bs mjac0bs mentioned this pull request Dec 11, 2023
Merged
@tbaka-akamai tbaka-akamai deleted the change/main_concept_demos branch April 15, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyler-akamai tyler-akamai tyler-akamai approved these changes

@cpathipa cpathipa cpathipa approved these changes

@hana-akamai hana-akamai hana-akamai approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

@bnussman-akamai bnussman-akamai Awaiting requested review from bnussman-akamai bnussman-akamai is a code owner automatically assigned from linode/frontend

Assignees

@tbaka-akamai tbaka-akamai

Labels
Approved Multiple approvals and ready to merge! Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tbaka-akamai @tyler-akamai @mjac0bs @hana-akamai @cpathipa @coliu-akamai