Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: Add linode_placement_group data source #1409

Merged
merged 5 commits into from
May 8, 2024

Conversation

yec-akamai
Copy link
Contributor

@yec-akamai yec-akamai commented May 1, 2024

📝 Description

Adding the data source linode_placement_group to read detailed information about a Linode placement group.

✔️ How to Test

make PKG_NAME="linode/placementgroup" int-test

Manual test:

  1. In a sandbox environment, i.e. dx-devenv, run the following script to read the linode_placement_group data source.
data "linode_placement_group" "test" {
    id = {your-pg-id}
}

output "result" {
    value = data.linode_placement_group.test
}
  1. Observe the detailed information of the above placement group is outputed.

@yec-akamai yec-akamai added the new-feature for new features in the changelog. label May 1, 2024
@yec-akamai yec-akamai requested a review from a team as a code owner May 1, 2024 18:45
@yec-akamai yec-akamai requested review from jriddle-linode and ykim-akamai and removed request for a team May 1, 2024 18:45
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests are all passing locally for me, nice work!

Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works locally.

@yec-akamai yec-akamai merged commit 3c131ee into proj/vm-placement May 8, 2024
7 checks passed
@yec-akamai yec-akamai deleted the TPT-2624/add-placement-group branch May 8, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature for new features in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants