-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new: Support control plane ACL in lke cluster resoure and datasource #1436
Conversation
@@ -143,8 +144,48 @@ var resourceSchema = map[string]*schema.Schema{ | |||
Optional: true, | |||
Computed: true, | |||
}, | |||
"acl": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed dropping the acl
block after applying a configuration with a valid ACL doesn't trigger any updates, similar to how we treat the nested disk
block in the linode_instance
resource. I think this behavior is probably fine/expected but I just wanted to bring attention to it just in case 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small changes and this should be good to go, excellent work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! working on my end!
📝 Description
Support control plane ACL CRUD operations in LKE cluster resource and data source. Because of the 1:1 relationship between cluster and ACL, we decided to manage ACL along with the cluster, instead of having an extra resource to do so.
✔️ How to Test
Manual test: