Reuse the client if it is already configured in fwprovider #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchinmai7
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
lgarber-akamai
approved these changes
Jun 7, 2024
jriddle-linode
approved these changes
Jun 10, 2024
zliang-akamai
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
Crossplane provider-linode expects to use a single configured instance of the linode client across all invocations. However, due to how upjet operates, the configureProvider() gets invoked on every resource call. To preserve the client, see if the fp.Meta.Client is already initialized, and if so, re-use it.
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
How do I run the relevant unit/integration tests?
The main thing here should be verifying it doesn't break any usual terraform flows.
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.