Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path for todo data so it's consistent on posix and win32 #30

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

renatoi
Copy link
Contributor

@renatoi renatoi commented Nov 30, 2020

posix.relative was returning an incorrect path for Windows (../app/app.js vs app/app.js) which was not consistent with the behavior on posix.

It looks like this is an known issue based on the following issues:

Since path.relative works correctly, we just need to normalize the path using the slash lib. Also, if the file path is already relative (this happens for ember-template-lint) then we can ignore the relative call, preventing the issue cited above.

src/builders.ts Show resolved Hide resolved
@scalvert scalvert merged commit 31544f7 into lint-todo:master Dec 1, 2020
@scalvert scalvert added the bug Something isn't working label Dec 1, 2020
@renatoi renatoi deleted the posix-fix branch December 2, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants