ci: publish only sdist on PyPi #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, when we figured out how we can get the versioning a bit more useful (looking into this as next) we can try to get TestPyPi hook more useful |
glimchb
reviewed
Apr 12, 2022
Pre building the binaries with wheels is difficult, as we would also need to ship the libnvme.so with the Python binding. This is a well known limitation of this kind of setup (binding to a shared library). Most project fallback to just ship the sdist. Though there is a drawback as the C library is missing and the user has to provide the library himself, with all problems which come along with setup. But it seems common practice with other Python bindings, so we don't want to be hostile to the ones which know what they are doing. Normal users should just use the distribution packages anyway. Signed-off-by: Daniel Wagner <dwagner@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre building the binaries with wheels is difficult, as we would also
need to ship the libnvme.so with the Python binding.
This is a well known limitation of this kind of setup (binding to a
shared library). Most project fallback to just ship the sdist.
Though there is a drawback as the C library is missing and the user
has to provide the library himself, with all problems which come along
with setup. But it seems common practice with other Python bindings,
so we don't want to be hostile to the ones which know what they are
doing.
Normal users should just use the distribution packages anyway.
Signed-off-by: Daniel Wagner dwagner@suse.de
Fixes: #271