Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/readme update #84

Closed
wants to merge 6 commits into from
Closed

Feature/readme update #84

wants to merge 6 commits into from

Conversation

robmusial
Copy link

Saw there was a place to add contact info for changes.

@dgraziotin
Copy link
Collaborator

Thanks for this! I will review it next week.

@dgraziotin
Copy link
Collaborator

Hi @rmusial. I have started looking at the pull requests. There is already a PR that touches the Makefile [#80], and I need to clarify something with the PR author there before taking yours into account. I am afraid that I will have to reject a couple of edits, such as the one here. The edit, while doing nothing harmful, does not comply with the mbpfan coding standard, that is K&R. I am to blame here because I have never written a coding style for mbpfan (just a subtle hint here).

@robmusial
Copy link
Author

No problem, thanks for the info. I'm going to keep those changes (for now) in my fork so it compiles without errors in clang. I'll look into it further to keep it inline with your preferred style guidelines.

@robmusial robmusial closed this Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants