Skip to content

Commit

Permalink
mlx5: Remove max_post assignment in create_qp()
Browse files Browse the repository at this point in the history
In create_qp(), RQ max_post value was redundantly overwritten after
being calculated already as part of mlx5_calc_rq_size().

This assumption that max_post is equal to wqe_cnt is not necessarily
true in all cases, as will be changed in upcoming patches where the OOO
RX support feature is introduced.

The line was removed, and the calculation is now handled by
mlx5_calc_rq_size() without overwriting its calculation.

Signed-off-by: Edward Srouji <edwards@nvidia.com>
Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
  • Loading branch information
EdwardSro authored and Yishai Hadas committed Nov 10, 2024
1 parent 7e8db6f commit e8eb3ef
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion providers/mlx5/verbs.c
Original file line number Diff line number Diff line change
Expand Up @@ -2638,7 +2638,6 @@ static struct ibv_qp *create_qp(struct ibv_context *context,
qp->get_ece = resp_drv->ece_options;
map_uuar(context, qp, resp_drv->bfreg_index, bf);

qp->rq.max_post = qp->rq.wqe_cnt;
if (attr->sq_sig_all)
qp->sq_signal_bits = MLX5_WQE_CTRL_CQ_UPDATE;
else
Expand Down

0 comments on commit e8eb3ef

Please sign in to comment.