bnxt_re/lib: driver fixes in resize_cq path #1495
Merged
+46
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library currently waits indefinitely for the resize CQ completion notification from the hardware. Due to hardware failure in handling the operation, there is a possible application hang. Add a loop count with a busy wait of definite time to avoid the application hang. Fixes: ae8b278 ("bnxt_re/lib: Resize CQ support") Signed-off-by: Chandramohan Akula <chandramohan.akula@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
During CQ resize, it is expected that the CQ doorbell 'epoch' needs to be maintained when switching from the old CQ to the new resized CQ. On the first CQ doorbell excecuted on the new CQ, we need to check if the index we are writing is less than the last index written for the old CQ. If that is the case, we need to flip the 'epoch' so the ASIC does not get confused and thinks the CQ doorbell is out of order and therefore drops the doorbell. Note the logic in the ASIC that checks CQ doorbell ordering is not aware of the CQ resize. Fixes: 4a85843 ("bnxt_re/lib: Fix the toggle bit changes in resize cq path") Signed-off-by: Ray Jui <ray.jui@broadcom.com> Reviewed-by: Chandramohan Akula <chandramohan.akula@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
In case of error completion, it is observed that vendor error code is always set to zero. Update to populate vendor error along with IB completions. Also, modified the log to display vendor error. Fixes: f158e23 ("libbnxt_re: Allow apps to poll for flushed completions") Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Reviewed-by: Selvin Xavier <selvin.xavier@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of fixes in resize_cq path.. Also, report the vendor error status.