Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to Kerberos principal #9

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

seocam
Copy link
Contributor

@seocam seocam commented Jun 1, 2020

No description provided.

@seocam seocam requested review from pcahyna and richm as code owners June 1, 2020 21:26
@seocam
Copy link
Contributor Author

seocam commented Jun 1, 2020

This PR doesn't have tests yet because OpenSSL does not support displaying Kerberos principals. I'll have to find a another way to print the principal in order to test.

Even in Python is not quite straightforward to see it (as you can see in the PR).

@seocam seocam force-pushed the principal branch 2 times, most recently from a98ae8d to a7cb18f Compare June 2, 2020 23:43
@seocam seocam requested a review from richm June 3, 2020 12:19
richm
richm previously approved these changes Jun 3, 2020
Copy link
Collaborator

@richm richm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@seocam
Copy link
Contributor Author

seocam commented Jun 3, 2020

Pylint failed because of a false-positive: https://travis-ci.com/github/linux-system-roles/certificate/jobs/343282623
The false positive bug still happens but mostly on Python2: pylint-dev/pylint#1498
I'll silence this error in that method.

@richm
Copy link
Collaborator

richm commented Jun 3, 2020

lgtm

@seocam seocam force-pushed the principal branch 3 times, most recently from d8d885b to 752d583 Compare June 3, 2020 20:57
@seocam seocam merged commit 045203b into linux-system-roles:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants