Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: tests update for pcs-0.12 and pacemaker-3 #238

Merged
merged 8 commits into from
Nov 28, 2024

Conversation

tomjelinek
Copy link
Member

Enhancement:
Update test scripts to work with the latest pcs and pacemaker versions

Reason:

Result:

Issue Tracker Tickets (Jira or BZ if any):

@tomjelinek tomjelinek requested a review from richm as a code owner November 1, 2024 14:40
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.50%. Comparing base (3ba798e) to head (fd00915).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   68.50%   68.50%           
=======================================
  Files           3        3           
  Lines         181      181           
=======================================
  Hits          124      124           
  Misses         57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomjelinek tomjelinek marked this pull request as draft November 1, 2024 16:25
@tomjelinek tomjelinek marked this pull request as ready for review November 18, 2024 14:43
@tomjelinek
Copy link
Member Author

[citest]

@tomjelinek
Copy link
Member Author

Python Unit Tests / python (ubuntu-24.04, main) is failing due to an issue in pcs that only happens on Ubuntu. This will be fixed in pcs later. All other Python Unit Tests are passing. I'm moving this PR from Draft to Ready so that needed fixes for testing latest cluster versions are not blocked unnecessarily.

This branch is also needed to be merged for #231

@spetrosi
Copy link
Collaborator

[citest bad]

@tomjelinek
Copy link
Member Author

CentOS-10 failures:

  • tests_cib_constraints_create - Caused by Pacemaker behaving like version 3 while announcing version 2. There is nothing that could be done about that. New release of Pacemaker will fix it.
  • tests_cib_rsc_op_defaults - Same as tests_cib_constraints_create
  • tests_sbd_* - Caused by a version mismatch between SBD and Pacemaker. There is nothing that could be done about that. New release of Pacemaker / SBD will fix it.
  • tests failing with "Error: unable to get cib" on TASK [fedora.linux_system_roles.ha_cluster : Set stonith-watchdog-timeout cluster property in CIB] - I'm not sure what's going on there and why it fails for some tests while passing for others. This error doesn't happen on any of my systems. It may get fixed once new packages get into CentOS.

@richm
Copy link
Contributor

richm commented Nov 19, 2024

@tomjelinek how long until there is a new release of pacemaker in the compose?

@tomjelinek
Copy link
Member Author

  • tests_cib_constraints_create - Caused by Pacemaker behaving like version 3 while announcing version 2. There is nothing that could be done about that. New release of Pacemaker will fix it.
  • tests_cib_rsc_op_defaults - Same as tests_cib_constraints_create

Correction: the latest pcs is also required for these tests to pass. It should get into the compose shortly, it was built yesterday. I'm also working on fixing these tests - they were originally checking Pacemaker version, which was not a good approach, as it just turned out.

how long until there is a new release of pacemaker in the compose?

Not sure about that. It was built recently, so hopefully in a couple of days.

@richm
Copy link
Contributor

richm commented Nov 20, 2024

  • tests_cib_constraints_create - Caused by Pacemaker behaving like version 3 while announcing version 2. There is nothing that could be done about that. New release of Pacemaker will fix it.
  • tests_cib_rsc_op_defaults - Same as tests_cib_constraints_create

Correction: the latest pcs is also required for these tests to pass. It should get into the compose shortly, it was built yesterday. I'm also working on fixing these tests - they were originally checking Pacemaker version, which was not a good approach, as it just turned out.

how long until there is a new release of pacemaker in the compose?

Not sure about that. It was built recently, so hopefully in a couple of days.

https://kojihub.stream.centos.org/koji/buildinfo?buildID=71808 - pcs-0.12.0~b1-1.el10 ?
I don't see it in https://mirror.stream.centos.org/10-stream/HighAvailability/x86_64/os/Packages/

@tomjelinek
Copy link
Member Author

[citest]

@tomjelinek
Copy link
Member Author

  • tests_cib_constraints_create - Caused by Pacemaker behaving like version 3 while announcing version 2. There is nothing that could be done about that. New release of Pacemaker will fix it.
  • tests_cib_rsc_op_defaults - Same as tests_cib_constraints_create

Correction: the latest pcs is also required for these tests to pass. It should get into the compose shortly, it was built yesterday. I'm also working on fixing these tests - they were originally checking Pacemaker version, which was not a good approach, as it just turned out.

This is fixed now.

how long until there is a new release of pacemaker in the compose?

Not sure about that. It was built recently, so hopefully in a couple of days.

Pacemaker packages are available already - pacemaker-3.0.0-2.el10

https://kojihub.stream.centos.org/koji/buildinfo?buildID=71808 - pcs-0.12.0~b1-1.el10 ? I don't see it in https://mirror.stream.centos.org/10-stream/HighAvailability/x86_64/os/Packages/

Yes, that's the one. Let's wait one more day, buttons have been pushed, hopefully this will make the pcs packages available.

@tomjelinek
Copy link
Member Author

tomjelinek commented Nov 21, 2024

CentOS-Stream-10|ansible-2.17 tests are failing due to broken SBD packages. Fixed SBD packages are expected to land on Monday.

@richm
Copy link
Contributor

richm commented Nov 25, 2024

[citest]

@tomjelinek
Copy link
Member Author

Still waiting for fixed sbd packages

@tomjelinek
Copy link
Member Author

[citest bad]

@tomjelinek
Copy link
Member Author

Fixed SBD packages are available in CentOS Stream 10. Tests are passing.

@tomjelinek tomjelinek merged commit 7e5752c into linux-system-roles:main Nov 28, 2024
21 of 26 checks passed
@tomjelinek tomjelinek deleted the tests-update branch November 28, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants