-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove python expect dependency in crmsh #249
Conversation
[citest] |
please rebase on top of the latest |
I have rebased branch and pushed it, let me know if it is alright now @richm |
[citest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the patch looks good to me. However, I'm not 100% sure about tasks/set_vars.yml changes. @richm, are you ok with those?
We have been using this vars loading for some time, because of how SLES_SAP is designed. This way we can separate between core SLES and SLES_SAP version without needing to create unnecessary var files for each product name. |
+1 - vars changes lgtm - I think the role has to do this because |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
=========================================
- Coverage 78.94% 0 -78.95%
=========================================
Files 6 0 -6
Lines 361 0 -361
=========================================
- Hits 285 0 -285
+ Misses 76 0 -76 ☔ View full report in Codecov by Sentry. |
Enhancement:
expect
module which required Pythonpexpect
module to be installedexpect
by using--force
andyes n
to skip all prompts and fail if user input is invalid or in conflict.resource_sets
handling.Reason:
Result:
SLES for SAP Applications 15 SP6
in AWS for SAP HANA, SAP ASCS/ERS and dummy clusters.