Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove python expect dependency in crmsh #249

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

marcelmamula
Copy link
Contributor

Enhancement:

  1. Remove all use of expect module which required Python pexpect module to be installed
  2. Replace expect by using --force and yes n to skip all prompts and fail if user input is invalid or in conflict.
  3. Enhance resource_sets handling.

Reason:

  • Extra python dependency was causing unnecessary dependencies

Result:

  • Tested on SLES for SAP Applications 15 SP6 in AWS for SAP HANA, SAP ASCS/ERS and dummy clusters.

@richm
Copy link
Contributor

richm commented Dec 11, 2024

[citest]

@richm
Copy link
Contributor

richm commented Dec 11, 2024

please rebase on top of the latest main branch

@marcelmamula
Copy link
Contributor Author

please rebase on top of the latest main branch

I have rebased branch and pushed it, let me know if it is alright now @richm

@spetrosi
Copy link
Collaborator

[citest]

Copy link
Member

@tomjelinek tomjelinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the patch looks good to me. However, I'm not 100% sure about tasks/set_vars.yml changes. @richm, are you ok with those?

@marcelmamula
Copy link
Contributor Author

Overall, the patch looks good to me. However, I'm not 100% sure about tasks/set_vars.yml changes. @richm, are you ok with those?

We have been using this vars loading for some time, because of how SLES_SAP is designed. This way we can separate between core SLES and SLES_SAP version without needing to create unnecessary var files for each product name.

@richm
Copy link
Contributor

richm commented Dec 12, 2024

Overall, the patch looks good to me. However, I'm not 100% sure about tasks/set_vars.yml changes. @richm, are you ok with those?

We have been using this vars loading for some time, because of how SLES_SAP is designed. This way we can separate between core SLES and SLES_SAP version without needing to create unnecessary var files for each product name.

+1 - vars changes lgtm - I think the role has to do this because os_family and/or distribution by themselves are not sufficient

@richm richm merged commit 7771830 into linux-system-roles:main Dec 12, 2024
18 of 24 checks passed
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (4be7b3c) to head (821fd47).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #249       +/-   ##
=========================================
- Coverage   78.94%      0   -78.95%     
=========================================
  Files           6      0        -6     
  Lines         361      0      -361     
=========================================
- Hits          285      0      -285     
+ Misses         76      0       -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants