Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intel/metadata: pretty print specific key manifests #400

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

orangecms
Copy link
Collaborator

This allows for better distinguishing them.

Note: I cannot get the manifest codegen to work in a Go module, so I manually made the changes as I understand it. Someone please verify.

See also: xaionaro-go/gosrc#1

This allows for better distinguishing them.

Signed-off-by: Daniel Maslowski <info@orangecms.org>
@xaionaro
Copy link
Member

It looks like manifestcodegen is broken by #394

The way you could use it is:

cd `go env GOPATH`/src/github.com/linuxboot/fiano/pkg/intel/metadata/cbnt
git remote add orangecms https://github.com/orangecms/fiano
git checkout print-as-key-manifest
GO111MODULE=off go run ./../common/manifestcodegen/cmd/manifestcodegen/ . ./cbntbootpolicy ./cbntkey

But it currently does weird stuff like this:

-       "github.com/linuxboot/fiano/pkg/intel/metadata/cbnt"
+       "github.com/linuxboot/fiano/pkg/intel/metadata/TODO_PACKAGE"
        "github.com/linuxboot/fiano/pkg/intel/metadata/common/pretty"

I'll fix this :(

Also https://github.com/linuxboot/fiano/blob/main/pkg/intel/metadata/README.md wasn't updated after #394 .

@xaionaro
Copy link
Member

Let's merge this PR as is, and the codegen I'll tackle soon.

@zaolin
Copy link
Contributor

zaolin commented Jan 17, 2023

That might be a bug I introduced @xaionaro

@orangecms orangecms merged commit 880dbe3 into linuxboot:main Jan 18, 2023
@orangecms orangecms deleted the print-as-key-manifest branch January 18, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants