-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't override system CMAKE_EXE_LINKER_FLAGS and don't set -fPIE… #352
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: felixonmars The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… for shared libraries - Append to CMAKE_EXE_LINKER_FLAGS instead of overriding it. - `-fPIE` is invalid for shared libraries. Removing it here fixes building for Arch. Please use --enable-default-pie for gcc instead of inserting PIE flags to every package.
e052f86
to
b16acf2
Compare
TAG Bot New tag: 5.10.39 |
TAG Bot New tag: 5.10.40 |
TAG Bot New tag: 5.10.41 |
TAG Bot New tag: 6.0.6 |
TAG Bot New tag: 5.10.42 |
TAG Bot New tag: 5.10.43 |
TAG Bot New tag: 5.10.44 |
TAG Bot New tag: 5.10.45 |
TAG Bot New tag: 5.10.46 |
TAG Bot New tag: 6.0.7 |
TAG Bot New tag: 6.0.8 |
TAG Bot New tag: 6.0.9 |
TAG Bot New tag: 6.0.10 |
TAG Bot New tag: 6.0.11 |
… for shared libraries
-fPIE
is invalid for shared libraries. Removing it here fixes building for Arch. Please use --enable-default-pie for gcc instead of inserting PIE flags to every package.