Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more web formats supported #30

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

Johnson-zs
Copy link
Contributor

.htm dhtml .xhtml .shtm .shtml

Log: as title

.htm dhtml .xhtml .shtm .shtml

Log:  as title
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • docparser.cpp文件中,isTextSuffix函数中的validSuffixes集合被修改,增加了"htm"和"dhtml"等后缀,但是没有提供修改的理由或背景。需要确认这些新后缀是否与产品功能和需求相符。
  • 检查是否有对应的单元测试来验证"htm"和"dhtml"等新后缀的功能和兼容性。

是否建议立即修改:

  • 是,如果新增的后缀"htm"和"dhtml"等与产品功能不符,或者没有进行充分的测试,那么应该立即进行修正。同时,建议提供详细的代码注释,解释为什么需要这些新增的后缀,以及它们是如何影响产品功能的。

Copy link

TAG Bot

TAG: 1.0.11
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, max-lvs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs Johnson-zs merged commit 6098951 into linuxdeepin:master May 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants