Refactor qml surfaceitem #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
ZhongYic00
force-pushed
the
refactor-qml-surfaceitem
branch
4 times, most recently
from
e995d2c
to
3b18feb
Compare
ZhongYic00
force-pushed
the
refactor-qml-surfaceitem
branch
4 times, most recently
from
945842b
to
aaaa24c
Compare
ZhongYic00
force-pushed
the
refactor-qml-surfaceitem
branch
2 times, most recently
from
5d3e687
to
adf9fa0
Compare
make surfaceItem a property of the factory item, initialized in C++ constructor (before property binding initial eval); use group-property for prop-binding convenience; eliminate some code of stackToplevelHelper & Helper, adapt to waylib shellSurface renaming. depends on vioken/waylib#369, vioken/waylib#361
ZhongYic00
force-pushed
the
refactor-qml-surfaceitem
branch
from
adf9fa0
to
aec8bf7
Compare
deepin pr auto reviewFix window geometry on launchpad |
justforlxz
approved these changes
Jun 18, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justforlxz, ZhongYic00 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sup-class of XdgSurface and XwaylandSurface in qml, merge common codes
depends on vioken/waylib#361, vioken/waylib#369