Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roll arm32 builds back to alpine 3.12 to avoid time64 change #130

Merged
merged 1 commit into from
Apr 11, 2021

Conversation

capntrips
Copy link
Contributor

@capntrips capntrips commented Apr 8, 2021

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Rolled buildstage back to alpine 3.12
Reverted #125 and installed py3-cryptography alpine package to avoid rust-lang/cargo#9187

Benefits of this PR and context:

Fixes #127 and potentially #124

How Has This Been Tested?

Deployed to Raspberry Pi 4 and tested basic functionality (download, check, repair, extract).

Source / References:

musl time64 Release Notes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@capntrips
Copy link
Contributor Author

capntrips commented Apr 8, 2021

I'm happy to apply the py3-cryptography change to the other Dockerfiles, if that would be preferable.

@capntrips
Copy link
Contributor Author

capntrips commented Apr 9, 2021

The issue I was having with building py cryptography must be something with my build system, as I had the same issue with alpine 3.13, and I see the weekly Jenkins build finished yesterday without issue.

Also, this may soon be redundant, as I appear to have fixed the time64 issue upstream. I submitted a pull request here. I have done some basic testing on Ubuntu 20.04 amd64 and Alpine 3.13 amd64 and armhf, and the issue seems to be resolved with no obvious bugs.

@tobbenb
Copy link
Member

tobbenb commented Apr 9, 2021

You are hitting the libseccomp error that has been an issue with focal on Ubuntu and on alpine after they started using 64bit time. So the best option is to update libseccomp or update to a 64bit OS.

@capntrips
Copy link
Contributor Author

# date
Fri Apr  9 09:28:14 CDT 2021

@Roxedus
Copy link
Member

Roxedus commented Apr 10, 2021

Just downgrading the buildstage should suffice.

@Roxedus Roxedus merged commit da8b0e0 into linuxserver:master Apr 11, 2021
@capntrips capntrips deleted the arm32v7-3.12-build branch April 12, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzbget segfaults with time64 on arm32
4 participants