Add support for DirectAdmin DNS validation #99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for DNS validation with DirectAdmin using plugin https://github.com/cybercinch/certbot-dns-directadmin
Benefits of this PR and context:
Currently it is not possible to perform DNS validation when a domain's DNS records are maintained on a (self-hosted) DirectAdmin instance.
How Has This Been Tested?
Built the container, pushed to Docker Hub (https://hub.docker.com/r/simonlepla/swag) and tested it on my setup. Worked well (tested custom DNS propagation time as well).
Settings (docker-compose):
Logs of the test (domain replaced with www.example.com):
Source / References:
https://github.com/cybercinch/certbot-dns-directadmin