Add an option to distribute reads among all nodes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @o1egl As your PR shows up, additional option targets the case that we could query to one of masters or one of slaves. The balancer only picks one that succeed. Is it your purpose? |
|
@linxGnu I added a description |
linxGnu
requested changes
May 27, 2020
| // ConnectMasterSlaves to master-slave databases, healthchecks will ensure they are working | ||
| // driverName: mysql, postgres, etc. | ||
| // masterDSNs: data source names of Masters. | ||
| // slaveDSNs: data source names of Slaves. | ||
| // args: args[0] = true to indicates galera/wsrep cluster. | ||
| func ConnectMasterSlaves(driverName string, masterDSNs []string, slaveDSNs []string, args ...interface{}) (*DBs, []error) { | ||
| func ConnectMasterSlaves(driverName string, masterDSNs []string, slaveDSNs []string, options ...Option) (*DBs, []error) { |
There was a problem hiding this comment.
I love currying options like these. Thank you!
o1egl
force-pushed
the
master
branch
2 times, most recently
from
21252c8
to
7db7567
Compare
|
@linxGnu thank you for your review. I addressed your comments. |
linxGnu
approved these changes
May 27, 2020
|
@o1egl Thank you very much for your contribution. It's great to see the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my current setup I have 1 master and 1 slave with 90% of read operations and 10% of write operations. This means that the resources of the host are not being used properly. The idea is to have and option to distribute read requests between the master and slave.