Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add basemapsCreatePullRequest.handler smoke test TDE-1030 #891

Merged
merged 7 commits into from
Nov 24, 2024
Merged

test: Add basemapsCreatePullRequest.handler smoke test TDE-1030 #891

merged 7 commits into from
Nov 24, 2024

Conversation

l0b0
Copy link
Contributor

@l0b0 l0b0 commented Feb 26, 2024 •
edited
Loading

Motivation

Enable refactoring the handler arguments by verifying a common, simple use case.

Modification

  • Mocks all relevant GithubApi methods to avoid any online calls.
  • Generates random input data to make it clear which parts of the input are relevant to the test (basically none of it is relevant).

Checklist

  • Tests updated
  • Docs updated (N/A)
  • Issue linked in Title

@l0b0 l0b0 requested review from a team as code owners February 26, 2024 22:13
@l0b0 l0b0 marked this pull request as draft February 26, 2024 22:13
@l0b0 l0b0 closed this Feb 27, 2024
@l0b0 l0b0 deleted the refactor/avoid-fsa-joinall branch February 27, 2024 02:36
@l0b0 l0b0 restored the refactor/avoid-fsa-joinall branch February 27, 2024 03:06
@l0b0 l0b0 reopened this Feb 27, 2024
@l0b0 l0b0 marked this pull request as ready for review February 27, 2024 03:07
@l0b0 l0b0 enabled auto-merge February 27, 2024 03:07
@l0b0 l0b0 requested a review from amfage March 10, 2024 19:21
amfage
amfage previously approved these changes Mar 11, 2024
View reviewed changes
blacha
blacha reviewed Mar 13, 2024
View reviewed changes
src/commands/basemaps-github/create-pr.ts Outdated Show resolved Hide resolved
src/utils/__test__/randomizers.test.ts Outdated Show resolved Hide resolved
src/commands/basemaps-github/__test__/create-pr.test.ts Outdated Show resolved Hide resolved
src/commands/basemaps-github/__test__/create-pr.test.ts Outdated Show resolved Hide resolved
@l0b0 l0b0 requested a review from blacha March 14, 2024 01:38
@l0b0 l0b0 requested a review from amfage March 17, 2024 20:22
@l0b0 l0b0 force-pushed the refactor/avoid-fsa-joinall branch from 1e9f098 to 399356a Compare March 18, 2024 20:21
@l0b0 l0b0 force-pushed the refactor/avoid-fsa-joinall branch from f4e4a2e to dcd3275 Compare October 14, 2024 02:23
l0b0 added a commit that referenced this pull request Nov 11, 2024
@l0b0
test: Use static values rather than random ones
ad2b7a1 
As per
<#891 (comment)>.
@l0b0 l0b0 added this pull request to the merge queue Nov 24, 2024
Merged via the queue into master with commit 9b81cd0 Nov 24, 2024
2 checks passed
@l0b0 l0b0 deleted the refactor/avoid-fsa-joinall branch November 24, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacha blacha blacha approved these changes

@MDavidson17 MDavidson17 Awaiting requested review from MDavidson17 MDavidson17 is a code owner automatically assigned from linz/li-topo-data-engineering

@paulfouquet paulfouquet Awaiting requested review from paulfouquet paulfouquet is a code owner automatically assigned from linz/li-topo-data-engineering

@amfage amfage Awaiting requested review from amfage

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l0b0 @blacha @amfage