Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

Intialise CDK Project #4

Closed
SPlanzer opened this issue Sep 17, 2020 · 5 comments · Fixed by #5
Closed

Intialise CDK Project #4

SPlanzer opened this issue Sep 17, 2020 · 5 comments · Fixed by #5

Comments

@SPlanzer
Copy link

@SPlanzer commented on Thu Sep 17 2020

Task

In order to build CD the CDK project must be initialised.

Acceptance Criteria

  • Peer review passed
@SPlanzer
Copy link
Author

SPlanzer commented Sep 17, 2020

cdk init app --language python

Results in

~ ~`cdk init` cannot be run in a non-empty directory!~ ~

This is as CDK init creates the project structure including invoking git init. (Though note, a fix is in place to ignore .git dir, See - aws/aws-cdk#1758)

It is therefore the readme and license causing this issue.

At the time of writing this issue, the plan is to move these files out, run cdk init and move them back in to the project

ignore the above - Not an issue if creating an infra dir

@SPlanzer
Copy link
Author

Result of running cdk init in root.

.
├── app.py
├── cdk.json
├── geospatial_data_lake
│   ├── geospatial_data_lake_stack.py
│   └── __init__.py
├── README.md
├── requirements.txt
├── setup.py
└── source.bat

This does not suffice as we want in in to infra dir.

Result of running cdk init in infra.

.
└── infra
    ├── app.py
    ├── cdk.json
    ├── infra
    │   ├── infra_stack.py
    │   └── __init__.py
    ├── README.md
    ├── requirements.txt
    ├── setup.py
    └── source.bat

This is better and more aligned with https://github.com/linz/linz-data-lake/tree/master/

though the sub-directory infra is confusing and should be renamed to be more like linz-data-lake infra (as below). Note data_stores rather than the infra sub-directory

.
├── app.py
├── cdk.json
├── data_stores
│   ├── __init__.py
│   └── raster_stack.py
├── README.md
└── requirements.txt

`` 

SPlanzer pushed a commit that referenced this issue Sep 17, 2020
@SPlanzer SPlanzer linked a pull request Sep 17, 2020 that will close this issue
@imincik
Copy link
Contributor

imincik commented Sep 21, 2020

@SPlanzer , nested infra directories looks to me as some mistake.

@SPlanzer
Copy link
Author

SPlanzer commented Sep 21, 2020

The result of cdk init was edited and the pull request is as below

├── infra
│   ├── app.py
│   ├── cdk.json
│   ├── data_stores
│   │   ├── __init__.py
│   │   └── raster_stack.py

This follows linz-data-lake which is as below


├── infra
│   ├── app.py
│   ├── cdk.json
│   ├── data_stores
│   │   ├── __init__.py
│   │   └── raster_stack.py

@imincik
Copy link
Contributor

imincik commented Sep 22, 2020

Looks good now.

SPlanzer pushed a commit that referenced this issue Sep 24, 2020
SPlanzer pushed a commit that referenced this issue Sep 24, 2020
SPlanzer pushed a commit that referenced this issue Sep 24, 2020
SPlanzer pushed a commit that referenced this issue Sep 24, 2020
imincik pushed a commit that referenced this issue Sep 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants