Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't limit footprint points, increase capture area buffer TDE-1049 #872

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

amfage
Copy link
Contributor

@amfage amfage commented Feb 23, 2024

Motivation

The default behaviour of gdal_footprint is to set a maximum limit of 100 points in each footprint. This is not enough for all tiles, resulting in some gaps between tiles and not enough detail on more complicated shapes. The solution is to allow unlimited points in tile footprints, and to increase the buffer distance used when simplifying the capture area.

A buffer size of 2 * gsd was chosen after some investigation, recorded in TDE-1049. The aim is to reduce the number of vertices and therefore the file size, while still describing the capture area in enough detail.

Modification

  • gdal_footprint use the -max_points unlimited option
  • Set the capture area to use 2 * gsd for the buffer distance.

Checklist

If not applicable, provide explanation of why.

  • Tests updated
  • Docs updated
  • Issue linked in Title

@amfage amfage changed the title fix: unlimited footprint points, increase buffer for capture area simplify fix: unlimited footprint points, increase buffer for capture area TDE-1049 Feb 23, 2024
@amfage amfage changed the title fix: unlimited footprint points, increase buffer for capture area TDE-1049 fix: no limit footprint points, increase buffer for capture area TDE-1049 Feb 23, 2024
@amfage amfage changed the title fix: no limit footprint points, increase buffer for capture area TDE-1049 fix: con't limit footprint points, increase buffer for capture area TDE-1049 Feb 23, 2024
@amfage amfage changed the title fix: con't limit footprint points, increase buffer for capture area TDE-1049 fix: don't limit footprint points, increase buffer for capture area TDE-1049 Feb 23, 2024
@amfage amfage changed the title fix: don't limit footprint points, increase buffer for capture area TDE-1049 fix: don't limit footprint points, increase capture area buffer TDE-1049 Feb 23, 2024
@amfage amfage marked this pull request as ready for review February 25, 2024 23:49
@amfage amfage requested a review from a team as a code owner February 25, 2024 23:49
@amfage amfage added this pull request to the merge queue Feb 26, 2024
Merged via the queue into master with commit c733f1e Feb 26, 2024
2 checks passed
@amfage amfage deleted the fix/capture-area-buffer-tde-1049 branch February 26, 2024 00:43
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants