Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify footprint geometry tde-1080 #891

Merged

Conversation

paulfouquet
Copy link
Collaborator

@paulfouquet paulfouquet commented Mar 5, 2024

Motivation

Since max_points unlimited has been introduced in the gdal_footprint call, generating the capture-area might take a very long time due to the complexity of the single footprint polygon that are merged.

Modification

Simplify single footprint geometry using the same buffer distance its used for the capture-area geometry.

From one test standardising Canterbury - Banks Peninsula LiDAR 1m DEM (2023) dataset, the create-collection step running time:

  • without simplifying footprints: 2m46s
  • simplifying footprints: 12s

Checklist

  • Tests updated
  • Docs updated
  • Issue linked in Title

@paulfouquet paulfouquet requested a review from l0b0 March 5, 2024 19:52
@paulfouquet paulfouquet added this pull request to the merge queue Mar 6, 2024
Merged via the queue into linz:master with commit a932a17 Mar 6, 2024
1 check passed
@paulfouquet paulfouquet deleted the feat/simplify-footprint-geometry-tde-1080 branch March 6, 2024 02:43
@github-actions github-actions bot mentioned this pull request Mar 6, 2024
github-merge-queue bot pushed a commit to linz/topo-workflows that referenced this pull request Mar 6, 2024
#### Motivation

linz/topo-imagery#891 needs `--gsd` to be passed
to standardise_validate script.

#### Modification

Pass the existing gsd parameter to standardise-validate step

**It needs a linz/topo-imagery#897 release.**

#### Checklist

- [ ] Tests updated N/A
- [ ] Docs updated N/A
- [x] Issue linked in Title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants