Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring in collection().addRelease() method and add styles and genres to WantListEntryReponse type #345

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

mlabod
Copy link
Contributor

@mlabod mlabod commented Oct 14, 2024

I found two tiny things that can be improved while working with the library

  1. The order of arguments folder and releaseId is swapped in the Documentation bit of the addRelease method
  2. The Discogs Api returns styles and genres for want list releases as well. Even though it's not part of their API docs it might be worth adding as it helps working with it in typescrip

@mlabod mlabod changed the title Fix docstring in collection().addRelease() method and add { styles, genres} to WantListEntryReponse type Fix docstring in collection().addRelease() method and add styles and genres to WantListEntryReponse type Oct 14, 2024
@lionralfs
Copy link
Owner

lionralfs commented Oct 15, 2024

Nice improvements, thank you @mlabod!

Released in 4.1.2 https://github.com/lionralfs/discogs-client/releases/tag/v4.1.2 🎉

@lionralfs lionralfs merged commit be21e14 into lionralfs:main Oct 15, 2024
3 checks passed
@mlabod
Copy link
Contributor Author

mlabod commented Oct 16, 2024

@lionralfs thanks! you're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants