Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch PHPCS from the squizlabs to phpcsstandards package #2

Closed
wants to merge 1 commit into from

Conversation

tomjn
Copy link

@tomjn tomjn commented Dec 3, 2023

The squizlabs package comes from a repo with no active admins, and active maintenance moved to the PHPCS Standards org, this repo should use the new package, especially given there are already phpcsstandards packages in use here

the squizlabs package comes from a repo with no active admins, and active maintenance moved to the PHPCS Standards org, this repo should use the new package
@lipemat lipemat changed the base branch from master to develop December 4, 2023 14:52
@mlipe-nxs
Copy link

I think it would be great to start using the new package, however both the wp-coding-standards and automattic packages are still using the squizlabs version as the runner and within the ruleset configurations.

I'm reluctant to have 2 versions of the basically the same package even though technically they have different namespaces.

Also, there are a lot of unit tests which fail after making this change which would need to be reconciled.

@lipemat
Copy link
Owner

lipemat commented Dec 4, 2023

Testing the new composer.json I also discovered the bin (phpcs and phpcbf) scripts still point to the squizlabs version which basically negates the value of making this change.

@jrfnl
Copy link

jrfnl commented Dec 7, 2023

Thank you for your support and your enthousiasm embracing the take-over of the PHP_CodeSniffer package.

In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted.

I'd recommend reverting the Composer reference changes and keeping the changes which refer to the repo URL on GitHub.

Sorry for the confusion and thank you for understanding. I hope you'll enjoy the 3.8.0 release, which I expect to release this Friday.

@tomjn tomjn closed this Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants