[TB 92 and 37]comments_async: update semantics and implement some fixes from a11y test #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 31f348e |
philli-m
changed the title
philli-m
force-pushed
the
pm-2023-09-comment-a11y
branch
3 times, most recently
from
98105a0
to
0de72e8
Compare
philli-m
changed the title
philli-m
changed the title
philli-m
force-pushed
the
pm-2023-09-comment-a11y
branch
from
0de72e8
to
677e9d6
Compare
philli-m
changed the title
goapunk
force-pushed
the
pm-2023-09-comment-a11y
branch
from
677e9d6
to
a9c0738
Compare
philli-m
force-pushed
the
pm-2023-09-comment-a11y
branch
from
9579016
to
7ba7bc1
Compare
philli-m
force-pushed
the
pm-2023-09-comment-a11y
branch
from
7ba7bc1
to
8e1ba4e
Compare
…nd removing sr only text when not needed
philli-m
force-pushed
the
pm-2023-09-comment-a11y
branch
from
8e1ba4e
to
31f348e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for the tech backlog stories concerning the comments, has been tested with a+ main, may need additional fixes when mB is updated but can be done in design sprint