Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublicKey API: plural fix #2057

Merged
merged 1 commit into from
Oct 3, 2023
Merged

PublicKey API: plural fix #2057

merged 1 commit into from
Oct 3, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Oct 3, 2023

Description

This PR fixes the plural resource name generation of PublicKey API.

As explained here, kubebuilder and kubernetes uses 2 different ways to generate plural names.

This is a temporary workaround, waiting for this PR kubernetes-sigs/kubebuilder#3408

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 changed the base branch from master to network-external October 3, 2023 08:18
@cheina97 cheina97 changed the title Frc/pubkeypluralfix PublicKey API: plural fix Oct 3, 2023
aleoli
aleoli approved these changes Oct 3, 2023
View reviewed changes
deployments/liqo/charts/liqo-crds/crds/networking.liqo.io_publickeies.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will probably be the old file to delete

@cheina97
Copy link
Member Author

cheina97 commented Oct 3, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 3, 2023
@adamjensenbot adamjensenbot merged commit 965ed32 into liqotech:network-external Oct 3, 2023
8 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 3, 2023
@cheina97 cheina97 deleted the frc/pubkeypluralfix branch October 3, 2023 14:22
@cheina97 cheina97 added the kind/breaking Breaking change label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

Assignees
No one assigned
Labels
kind/breaking Breaking change size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheina97 @adamjensenbot @aleoli