Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: ipmappings #2711

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Docs: ipmappings #2711

merged 2 commits into from
Sep 2, 2024

Conversation

cheina97
Copy link
Member

Description

This PR adds a documentation page about external host IP remapping.

It also refactors the labels used by the controllers to select the IP resources that need firewall rules inside the gateways.

@cheina97
Copy link
Member Author

/build

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 marked this pull request as ready for review August 30, 2024 10:50
@fra98 fra98 added the kind/docs Improvements or additions to documentation label Aug 30, 2024
docs/advanced/external-ip-remapping.md Outdated Show resolved Hide resolved
docs/advanced/external-ip-remapping.md Outdated Show resolved Hide resolved
docs/advanced/external-ip-remapping.md Outdated Show resolved Hide resolved
docs/advanced/external-ip-remapping.md Outdated Show resolved Hide resolved
docs/advanced/external-ip-remapping.md Show resolved Hide resolved
docs/advanced/external-ip-remapping.md Outdated Show resolved Hide resolved
docs/advanced/external-ip-remapping.md Show resolved Hide resolved
cheina97 and others added 2 commits September 2, 2024 12:00
Co-authored-by: Francesco Torta <62566275+fra98@users.noreply.github.com>
@cheina97
Copy link
Member Author

cheina97 commented Sep 2, 2024

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Sep 2, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 2, 2024
@adamjensenbot adamjensenbot merged commit 588b5e9 into liqotech:master Sep 2, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 2, 2024
@cheina97 cheina97 deleted the frc/ipmapping branch September 2, 2024 13:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs Improvements or additions to documentation size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants