Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags package refactoring: from "flag" to "pflag" #2725

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Flags package refactoring: from "flag" to "pflag" #2725

merged 1 commit into from
Sep 9, 2024

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Sep 9, 2024

Description

This PR refactors the flags used by liqo, changing the default package from flag to pflag

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97 cheina97 marked this pull request as draft September 9, 2024 09:05
@cheina97 cheina97 changed the title Flags package refactoring Flags package refactoring: from "flag" to "pflag" Sep 9, 2024
@cheina97
Copy link
Member Author

cheina97 commented Sep 9, 2024

/build

@cheina97 cheina97 force-pushed the frc/pflag branch 2 times, most recently from 12df5ea to 943a4ff Compare September 9, 2024 10:43
@cheina97
Copy link
Member Author

cheina97 commented Sep 9, 2024

/build

@cheina97
Copy link
Member Author

cheina97 commented Sep 9, 2024

/build

@cheina97 cheina97 marked this pull request as ready for review September 9, 2024 10:57
@cheina97
Copy link
Member Author

cheina97 commented Sep 9, 2024

/rebase test=true

@fra98 fra98 added the kind/cleanup Refactoring code label Sep 9, 2024
@cheina97
Copy link
Member Author

cheina97 commented Sep 9, 2024

/rebase test=true

aleoli
aleoli approved these changes Sep 9, 2024
View reviewed changes
cmd/liqoctl/cmd/root.go Show resolved Hide resolved
@cheina97
Copy link
Member Author

cheina97 commented Sep 9, 2024

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 9, 2024
@adamjensenbot adamjensenbot merged commit 3a02bba into liqotech:master Sep 9, 2024
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@fra98 fra98 Awaiting requested review from fra98

Assignees
No one assigned
Labels
kind/cleanup Refactoring code size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cheina97 @adamjensenbot @aleoli @fra98