fix: avoid creation of VirtualNode if ResourceSlice deleting #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheina97
approved these changes
Oct 24, 2024
|
Hi @fra98. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
/rebase test=true |
adamjensenbot
force-pushed
the
frt/fix-rs-deleting
branch
from
d4f3066
to
29ab9ba
Compare
|
/rebase test=true |
adamjensenbot
force-pushed
the
frt/fix-rs-deleting
branch
from
29ab9ba
to
b5eae60
Compare
|
/rebase test=true |
adamjensenbot
force-pushed
the
frt/fix-rs-deleting
branch
from
b5eae60
to
40f5d5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the virtualnode resource was created even when the owner resourceslice was deleting.
This fix helps deleting the offloading when using GitOps tools like ArgoCD.