[Feat] liqoctl gateway template check #2791
Conversation
|
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
cheina97
force-pushed
the
frc/templatecheck
branch
from
51ea3b0
to
675d0dd
Compare
cheina97
changed the title
cheina97
requested review from
claudiolor,
aleoli and
fra98
and removed request for
claudiolor,
aleoli and
fra98
cheina97
force-pushed
the
frc/templatecheck
branch
from
675d0dd
to
1f68d98
Compare
| @@ -36,6 +36,7 @@ spec: | |||
| - port: "{{"{{ .Spec.Endpoint.Port }}"}}" | |||
| protocol: UDP | |||
| targetPort: "{{"{{ .Spec.Endpoint.Port }}"}}" | |||
|
|
|||
There was a problem hiding this comment.
We should align this file to the eks one also on what concerns empty lines
| if err := cluster1.CheckTemplateGwClient(ctx, o); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // Check if the Templates exists and is valid on cluster 2 | ||
| if err := cluster2.CheckTemplateGwServer(ctx, o); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
We should add a flag to skip these checks
|
|
||
| // GetNestedField returns the nested field of a map. | ||
| // Example: GetNestedField(map[string]interface{}{"a": map[string]interface{}{"b": "c"}}, "a.b") returns "c". | ||
| func GetNestedField(m map[string]interface{}, path string) (interface{}, error) { |
There was a problem hiding this comment.
In modern go, I think any type is identical to interface{} and more idiomatic. Not entirely sure about this
|
|
||
| _, err = maps.GetNestedField(port, "nodePort") | ||
| if err != nil { | ||
| return fmt.Errorf("unable to get spec.template.spec.service.spec.ports[0].nodePort int the server template, " + |
There was a problem hiding this comment.
Once we add a flag to skip this check (as suggested by aleoli), we can add a suggestion of how to skip this check. Morevoer, we might also add a documentation page explaining the concept of template and how to add a field in the template, so that we can add a link to it in the error message
cheina97
force-pushed
the
frc/templatecheck
branch
from
1f68d98
to
7d0788e
Compare
Description
This PR adds some checks in liqoctl (at peering time) about the gateway template used.
This checks are:
--server-service-nodeportflag has been specified, it checks if the template selected support static nodeports--server-service-loadbalanceripflag has been specified, it checks if the template selected support static load balancer ips