feat: ensure that mvms can be scheduled onto multiple hosts #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change: - Bumps the flintlock client and api, and updates the way we now make Get and Delete requests: these are now done by UID not name/ns. - Sets the unique id returned from the flintlock create as the providerID on the MvmMachine.
We were using a mix of consts and func params and it was messing me up.
We previously assumed that the failureDomain would be set on the Machine Spec and that we could use that to determine placement. This is eventually the case, but is set after a create is complete. If we don't want to have duplicate mvms created on every host, then we need to save this on our own MicrovmMachine Spec.
Callisto13
force-pushed
the
unique-id
branch
2 times, most recently
from
098523f
to
f35d593
Compare
This was
linked to
issues
Jan 31, 2022
yitsushi
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two pieces to this:
The second one is the main thing that stops dupe mvms from appearing on every device, but the changes make sense together.
fix: save failureDomain on mvm spec
We previously assumed that the failureDomain would be set on the
Machine Spec and that we could use that to determine placement.
This is eventually the case, but is set after a create is complete.
If we don't want to have duplicate mvms created on every host, then we
need to save this on our own MicrovmMachine Spec.
chore: tidy up tests
We were using a mix of consts and func params and it was messing me up.
feat: use flintlock uuid for mvmmachine providerID
This change:
Get and Delete requests: these are now done by UID not name/ns.
providerID on the MvmMachine.