Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use local_hostname from instance metadata for node registration #126

Merged
merged 3 commits into from
Feb 2, 2022
Merged

feat: use local_hostname from instance metadata for node registration #126

merged 3 commits into from
Feb 2, 2022

Conversation

Callisto13
Copy link
Member

Closes #112

@Callisto13 Callisto13 added the kind/feature New feature or request label Jan 31, 2022
@Callisto13 Callisto13 changed the title wip feat: use local_hostname from instance metadata for node registration Feb 1, 2022
@Callisto13 Callisto13 marked this pull request as ready for review February 1, 2022 14:14
@Callisto13 Callisto13 requested a review from a team February 1, 2022 16:40
@Callisto13 Callisto13 merged commit 21d998e into main Feb 2, 2022
@Callisto13 Callisto13 deleted the kubeadm-node-name branch February 2, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yitsushi yitsushi yitsushi approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the template to remove PROVIDER_ID
2 participants
@Callisto13 @yitsushi