feat: provider id changes #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardcase
force-pushed
the
testing_changes
branch
2 times, most recently
from
257ae3a
to
cc6563f
Compare
richardcase
force-pushed
the
testing_changes
branch
from
cc6563f
to
7c094c4
Compare
Callisto13
previously approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Don't forget to update https://github.com/weaveworks/cluster-api-provider-microvm/blob/main/metadata.yaml before you release
Changed the machine reconciliation so that it uses the standard format for the provider id with uses a prefix. The prefix for this provider is `microvm://`. The provider id is parsed when looking up the status of the microvm. Additionally, the ability to explicitly set a proxy server for the microvm service has been added to the APIs. This is for scenarios where you don't want to use the HTTP[S]_PROXY env vars. Signed-off-by: Richard Case <richard@weave.works>
richardcase
force-pushed
the
testing_changes
branch
from
7c094c4
to
23ef72c
Compare
Callisto13
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Changed the machine reconciliation so that it uses the standard format
for the provider id with uses a prefix. The prefix for this provider is
microvm://. The provider id is parsed when looking up the status ofthe microvm.
Additionally, the ability to explicitly set a proxy server for the
microvm service has been added to the APIs. This is for scenarios where
you don't want to use the HTTP[S]_PROXY env vars.
Also setting the cluster name correctly in the instance metadata.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #139
Fixes #138
Fixes #132
Fixes #120
Special notes for your reviewer:
Checklist: