feat: Change machine api to additional kernel args
#63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitsushi
force-pushed
the
45-additional-kernel-args
branch
from
2c64154
to
8e18fa3
Compare
Callisto13
previously approved these changes
Dec 17, 2021
|
Based on the comments under liquidmetal-dev/flintlock#320 i'll put this back to draft and when the flintlock side it done, i'll make changes here too. |
yitsushi
force-pushed
the
45-additional-kernel-args
branch
from
8e18fa3
to
c879a53
Compare
yitsushi
force-pushed
the
45-additional-kernel-args
branch
from
c879a53
to
f4ae133
Compare
Update flintlock/api
yitsushi
force-pushed
the
45-additional-kernel-args
branch
from
f4ae133
to
32971c8
Compare
yitsushi
changed the title
additional kernel argsadditional kernel args
jmickey
approved these changes
Jan 25, 2022
Callisto13
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I think KernelCmdLine is a good field and no need to rename it if the
documentation around that field is clean about being additional.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):fixes #45
Special notes for your reviewer:
Checklist: