Skip to content

Commit

Permalink
feat: Enable SMT when GOARCH == amd64 (#562)
Browse files Browse the repository at this point in the history
I have done this very simply for now as this is the only setting I have
so far found which is not supported on ARM. If/when I find there are
more features which vary based on architecture we can make this more
elaborate, but for now this will work for us.
  • Loading branch information
Callisto13 authored Oct 17, 2022
1 parent 9f64a55 commit 76a0a37
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion infrastructure/firecracker/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package firecracker
import (
"encoding/base64"
"fmt"
"runtime"

"github.com/firecracker-microvm/firecracker-go-sdk"
cinetwork "github.com/weaveworks-liquidmetal/flintlock/client/cloudinit/network"
Expand Down Expand Up @@ -39,7 +40,7 @@ func WithMicroVM(vm *models.MicroVM) ConfigOption {
cfg.MachineConfig = MachineConfig{
MemSizeMib: vm.Spec.MemoryInMb,
VcpuCount: vm.Spec.VCPU,
SMT: true,
SMT: runtime.GOARCH == "amd64",
}

mmdsNetDevices := []string{}
Expand Down

0 comments on commit 76a0a37

Please sign in to comment.