Pin firecracker to v0.25.2-macvtap for nightly e2es
#401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callisto13
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## main #401 +/- ##
==========================================
+ Coverage 56.89% 56.93% +0.03%
==========================================
Files 52 52
Lines 2626 2626
==========================================
+ Hits 1494 1495 +1
+ Misses 1005 1003 -2
- Partials 127 128 +1
Continue to review full report at Codecov.
|
Previously we were writing `"discard_blocks": "true"` with `true` as a string. In recent containerds they are being more strict on type, so now we set it as a bool. Also I accidentally messed up the path, and did some weird things with other vars. Now the containerd config file is written to `/etc/containerd/config-e2e.toml` not `/etc/containerd/config-e2e.toml/config-e2e.toml`.
Callisto13
force-pushed
the
fix-ctrd-test-path
branch
from
870a694
to
d270158
Compare
Callisto13
changed the title
v0.25.2-macvtap for nightly e2es
yitsushi
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin firecracker to v0.25.2-macvtap for e2e tests.
Can be undone after #390
Previously we were writing
"discard_blocks": "true"withtrueas astring in the containerd config generated for the tests.
In recent containerds they are being more strict on type, so
now we set it as a bool.
Also I accidentally messed up the path, and did some weird things with other
vars. Now the containerd config file is written to
/etc/containerd/config-e2e.tomlnot
/etc/containerd/config-e2e.toml/config-e2e.toml.Closes #400