patch: Provision flintlock from latest release #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitsushi
previously approved these changes
Jul 21, 2022
| @@ -294,7 +294,7 @@ install_flintlockd() { | |||
| say "Installing flintlockd version $tag to $INSTALL_PATH" | |||
|
|
|||
| if [[ "$tag" == "$DEFAULT_VERSION" ]]; then | |||
| tag=$(latest_pre_release_tag "$FLINTLOCK_REPO") | |||
| tag=$(latest_release_tag "$FLINTLOCK_REPO") | |||
There was a problem hiding this comment.
Do we need the latest_pre_release_tag function after this patch?
There was a problem hiding this comment.
technically no. i know i am usually ruthless when it comes to deleting dead code, but for some reason I had great attachment to this one 🤣
There was a problem hiding this comment.
it's dead i killed it hope you are happy 😭 😭
Previously flintlock only had pre-releases, which meant a different install method in `provision.sh`. Now it can use the standard func.
Callisto13
force-pushed
the
update-install-flint-provision
branch
from
163f436
to
6203ec8
Compare
richardcase
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously flintlock only had pre-releases, which meant a different
install method in
provision.sh. Now it can use the standard func.Also update the compatibility table and add a note about supported
Firecracker versions.