feat: Add "insecure" opt to provisioner #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will give the option to start flintlock without basic auth or certs. I am adding the options for those next, just needed `--insecure` first.
yitsushi
approved these changes
Jul 21, 2022
| @@ -321,6 +323,7 @@ containerd-socket: "$CONTAINERD_STATE_DIR/containerd.sock" | |||
| grpc-endpoint: "$address:9090" | |||
| verbosity: 9 | |||
| parent-iface: "$parent_iface" | |||
| insecure: $insecure | |||
There was a problem hiding this comment.
Any checks if $insecure contains 1|0 or true|false, or in that case we just say "user error, Read The Fancy Manual"
There was a problem hiding this comment.
I am doing more around this soon, so this will likely change, just need to get unblocked on something.
We don't validate other inputs (for this users cannot actually give any input since it is a bool flag) so perhaps that is a ticket for another day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give the option to start flintlock without basic auth or
certs.
I am adding the options for those next, just needed
--insecurefirst.