refactor: move validation/defaults to app #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callisto13
reviewed
Aug 22, 2022
core/application/commands.go
Outdated
| @@ -171,3 +186,24 @@ func (a *app) addInstanceData(vm *models.MicroVM, logger *logrus.Entry) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (a *app) addMetadataInterface(mvm *models.MicroVM) error { | |||
There was a problem hiding this comment.
This could probably return a bool rather than an error. The caller is doing fmt.Errorf("adding metadata network interface: %w", err) but the func never returns an err.
Actually, in that case does it need to return anything? It could just return nothing on 194 and leave the func early
There was a problem hiding this comment.
Thats a good point. Changed.
This change moves the adding of the mmds network interface and validation of the microvm spec to the app and out of the gRPC infrastructure. Signed-off-by: Richard Case <richard.case@outlook.com>
Callisto13
reviewed
Aug 22, 2022
| }, | ||
| }) | ||
|
|
||
| return |
There was a problem hiding this comment.
this last return is likely redundant
Callisto13
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change moves the adding of the mmds network interface and
validation of the microvm spec to the app and out of the gRPC
infrastructure.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #513
Special notes for your reviewer:
Checklist: