Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fc build instruction to be more useful #517

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Update fc build instruction to be more useful #517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/fork.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:

To complete work on this Issue:
- [ ] Update (merge or rebase) the [fork macvtap feature branch](https://github.com/weaveworks/firecracker/tree/feature/macvtap) to the latest upstream release tag ${{ env.NEW_VERSION }}. **Note: Do not update the feature branch to upstream main.**
- [ ] Make sure it builds. (See: [doc](https://github.com/weaveworks-liquidmetal/flintlock/blob/main/docs/quick-start.md#set-up-firecracker))
- [ ] Make sure it builds. (`tools/devtool build`)
- [ ] Push the updated firecracker 'feature/macvtap' fork branch.
- [ ] Create a new tag on the updated firecracker 'feature/macvtap' fork branch: `git tag -s ${{ env.NEW_VERSION}}-macvtap -m ${{ env.NEW_VERSION }}-macvtap`.
- [ ] Push the tag to the fork: `git push <remote> ${{ env.NEW_VERSION }}-macvtap` (A new [release](https://github.com/weaveworks/firecracker/releases) will be created.)
Expand Down