Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update provision.sh to detect arch #552

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

Callisto13
Copy link
Member

@Callisto13 Callisto13 commented Oct 11, 2022

edit: Actually realised I don't like the flags and that the idea in #549 is correct: we should detect.

Also take care of any backwards compatibility for those downloading earlier firecracker versions which were named differently.

Closes #376
Closes #548

@Callisto13 Callisto13 added the kind/feature New feature or request label Oct 11, 2022
@Callisto13
Copy link
Member Author

Reminder to make FC release a non-pre release after this is merged

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 56.53% // Head: 56.61% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (da9fd20) compared to base (67a19de).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   56.53%   56.61%   +0.07%     
==========================================
  Files          57       57              
  Lines        2768     2768              
==========================================
+ Hits         1565     1567       +2     
+ Misses       1061     1059       -2     
  Partials      142      142              
Impacted Files Coverage Δ
infrastructure/containerd/event_service.go 59.64% <0.00%> (+3.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Callisto13 Callisto13 changed the title feat: Add provision flags to download ARM binaries feat: Update provision.sh to detect arch Oct 11, 2022
Also take care of any backwards compatibility for those downloading
earlier firecracker versions which were named differently.
@Callisto13 Callisto13 merged commit 9e3c949 into liquidmetal-dev:main Oct 13, 2022
@Callisto13 Callisto13 deleted the arm branch October 13, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provision script cannot download arch-specific firecracker builds Update provision.sh to install arm64 bins
3 participants