Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed gw command #627

Merged
merged 2 commits into from
Mar 4, 2023

Conversation

richardcase
Copy link
Member

@richardcase richardcase commented Feb 11, 2023

What this PR does / why we need it:

The separate gw command has been removed and its functionality incorporated into the run command. The HTTP gateway is then enabled using --enable-http.

NOTE: the code to start the HTTP gateway remains the same. We will need to refactor it in the future to take into account the TLS flags.

The reason for making this change is that we should be able to enable the grpc and http endpoints with the same instance of flintlock instead of having to start 2 instances.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@richardcase richardcase added the kind/refactor Only refactoring changes label Feb 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.10 🎉

Comparison is base (d51af02) 56.29% compared to head (3b9d41e) 56.40%.

❗ Current head 3b9d41e differs from pull request most recent head c733ebf. Consider uploading reports for the commit c733ebf to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
+ Coverage   56.29%   56.40%   +0.10%     
==========================================
  Files          57       57              
  Lines        2780     2780              
==========================================
+ Hits         1565     1568       +3     
+ Misses       1071     1070       -1     
+ Partials      144      142       -2     
Impacted Files Coverage Δ
pkg/process/process.go 39.62% <0.00%> (+1.88%) ⬆️
pkg/queue/queue.go 100.00% <0.00%> (+6.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Callisto13
Callisto13 previously approved these changes Feb 13, 2023
The separate `gw` command has been removed and its functionality
incorporated into the `run` command. The HTTP gateway is then enabled
using `--enable-http`.

NOTE: the code to start the HTTP gateway remains the same. We will need
to refactor it in the future to take into account the the TLS flags.

Signed-off-by: Richard Case <richard.case@outlook.com>
@yitsushi yitsushi enabled auto-merge (squash) March 4, 2023 21:19
@yitsushi yitsushi merged commit fc3739d into liquidmetal-dev:main Mar 4, 2023
@Callisto13
Copy link
Member

ummm i don't think this was ready to go @yitsushi

I remember @richardcase saying something about forgetting to do auth and other bits

@yitsushi
Copy link
Contributor

yitsushi commented Mar 6, 2023

Well it was not in Draft mode and not much changes since you approved 2 weeks ago.

@Callisto13
Copy link
Member

yeh this was a verbal chat in the community meeting

@richardcase
Copy link
Member Author

It was ready to go. This is the note I added to the PR:

NOTE: the code to start the HTTP gateway remains the same. We will need to refactor it in the future to take into account the TLS flags.

So, this was refactoring and not adding TLS etc, which would need to be done separatly.

@Callisto13
Copy link
Member

okay cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactor Only refactoring changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants