-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: removed gw
command
#627
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #627 +/- ##
==========================================
+ Coverage 56.29% 56.40% +0.10%
==========================================
Files 57 57
Lines 2780 2780
==========================================
+ Hits 1565 1568 +3
+ Misses 1071 1070 -1
+ Partials 144 142 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
d5cc2e1
to
4b51ac1
Compare
The separate `gw` command has been removed and its functionality incorporated into the `run` command. The HTTP gateway is then enabled using `--enable-http`. NOTE: the code to start the HTTP gateway remains the same. We will need to refactor it in the future to take into account the the TLS flags. Signed-off-by: Richard Case <richard.case@outlook.com>
4b51ac1
to
b4817bd
Compare
ummm i don't think this was ready to go @yitsushi I remember @richardcase saying something about forgetting to do auth and other bits |
Well it was not in Draft mode and not much changes since you approved 2 weeks ago. |
yeh this was a verbal chat in the community meeting |
It was ready to go. This is the note I added to the PR:
So, this was refactoring and not adding TLS etc, which would need to be done separatly. |
okay cool |
What this PR does / why we need it:
The separate
gw
command has been removed and its functionality incorporated into therun
command. The HTTP gateway is then enabled using--enable-http
.The reason for making this change is that we should be able to enable the grpc and http endpoints with the same instance of flintlock instead of having to start 2 instances.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: