Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add dependabot bundler #647

Merged
merged 3 commits into from
Mar 4, 2023
Merged

chore(deps): add dependabot bundler #647

merged 3 commits into from
Mar 4, 2023

Conversation

Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Mar 3, 2023

The bundler PRs are getting out of control. Let's try and rein them in.
This will also add the correct label so the label checker doesn't croak.

kind/feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Skarlso Skarlso added the kind/feature New feature or request label Mar 3, 2023
@Skarlso Skarlso requested review from Callisto13 and yitsushi March 3, 2023 08:02
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (9b9559f) 56.40% compared to head (dab13d1) 56.47%.

❗ Current head dab13d1 differs from pull request most recent head 2da132e. Consider uploading reports for the commit 2da132e to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
+ Coverage   56.40%   56.47%   +0.07%     
==========================================
  Files          57       57              
  Lines        2780     2780              
==========================================
+ Hits         1568     1570       +2     
+ Misses       1070     1068       -2     
  Partials      142      142              
Impacted Files Coverage Δ
infrastructure/containerd/event_service.go 59.64% <0.00%> (+3.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Skarlso Skarlso force-pushed the bundler-github-action branch 6 times, most recently from 2ec50a9 to 3d2a338 Compare March 3, 2023 11:00
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 3, 2023

The resulting PR looks good #649

The bundler PRs are getting out of control. Let's try and rein them in.
@Skarlso Skarlso force-pushed the bundler-github-action branch from 3d2a338 to f91d8f3 Compare March 3, 2023 11:07
Copy link
Contributor

@yitsushi yitsushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked a generated PR. That doesn't work
image

@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 3, 2023

Ah freck.

@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 3, 2023

I guess I need a way to pass in a signing key to the bot.

@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 4, 2023

Finalllly! The latest version added verification. I'll release it and use that. Hopefully, it will work. :D

Screenshot 2023-03-04 at 14 14 38

@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 4, 2023

Screenshot 2023-03-04 at 16 32 19

@Skarlso Skarlso force-pushed the bundler-github-action branch from ad503f0 to 4f282fb Compare March 4, 2023 15:49
@Skarlso Skarlso requested a review from yitsushi March 4, 2023 15:52
@Skarlso Skarlso force-pushed the bundler-github-action branch from 4f282fb to 7f69d37 Compare March 4, 2023 15:52
@Skarlso Skarlso dismissed yitsushi’s stale review March 4, 2023 16:06

Added signing to the bundler.

@Skarlso Skarlso force-pushed the bundler-github-action branch from 3a26568 to 2da132e Compare March 4, 2023 20:07
@@ -542,6 +543,13 @@ while lower priority or nice-to-have things may take a little longer to get appr
To help facilitate a smoother and faster review, follow the guidelines [above](#pr-submission-guidelines).
Submissions which do not meet standards will be de-prioritised for review.

## Dependabot Bundler

There is an action that will periodically bundle dependabot pull requests into a single
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can extend this if more info is required. Maybe with a link to the action once it's available. Or a sample PR once there is one. :)

@yitsushi yitsushi merged commit 9a37560 into main Mar 4, 2023
yitsushi pushed a commit that referenced this pull request Mar 4, 2023
* chore(deps): add dependabot bundler

The bundler PRs are getting out of control. Let's try and rein them in.

* updating the action to use signing

* remove pgp signing and add label
Signed-off-by: Balazs Nadasdi <balazs@weave.works>
yitsushi added a commit that referenced this pull request Mar 4, 2023
* Bundling updated dependencies.

* chore(deps): add dependabot bundler (#647)

* chore(deps): add dependabot bundler

The bundler PRs are getting out of control. Let's try and rein them in.

* updating the action to use signing

* remove pgp signing and add label
Signed-off-by: Balazs Nadasdi <balazs@weave.works>

---------

Co-authored-by: Github Action <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Co-authored-by: Balazs Nadasdi <balazs@weave.works>
@Skarlso Skarlso deleted the bundler-github-action branch October 2, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants