You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, absinthe will accept either emails or participant ids in createDelegation mutation, but only the create_delegation/1 clause that matches the emails case will subsequently apply a range of validations and conflict resolutions to the delegation creation process.
A (simple) refactoring of the clauses should accommodate both cases.
May well also require a number of new related tests.
The text was updated successfully, but these errors were encountered:
Sounds good. Just a quick pedantic clarification - by definition refactors don't change functionality. It's only about reorganizing code, while keeping the system working the same as before.
jinjagit
changed the title
Refactor multi-clause create_delegation/1 to use all validations when attrs include participant_ids
Change multi-clause create_delegation/1 to use all validations when attrs include participant_ids
Oct 2, 2020
Sounds good. Just a quick pedantic clarification - by definition refactors don't change functionality. It's only about reorganizing code, while keeping the system working the same as before.
Currently, absinthe will accept either emails or participant ids in createDelegation mutation, but only the create_delegation/1 clause that matches the emails case will subsequently apply a range of validations and conflict resolutions to the delegation creation process.
A (simple) refactoring of the clauses should accommodate both cases.
May well also require a number of new related tests.
The text was updated successfully, but these errors were encountered: