Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change multi-clause create_delegation/1 to use all validations when attrs include participant_ids #137

Closed
jinjagit opened this issue Sep 25, 2020 · 3 comments · Fixed by #143
Assignees

Comments

@jinjagit
Copy link
Member

jinjagit commented Sep 25, 2020

Currently, absinthe will accept either emails or participant ids in createDelegation mutation, but only the create_delegation/1 clause that matches the emails case will subsequently apply a range of validations and conflict resolutions to the delegation creation process.

A (simple) refactoring of the clauses should accommodate both cases.

May well also require a number of new related tests.

@jinjagit
Copy link
Member Author

jinjagit commented Oct 2, 2020

This will probably also resolve #128

@oliverbarnes
Copy link
Member

Sounds good. Just a quick pedantic clarification - by definition refactors don't change functionality. It's only about reorganizing code, while keeping the system working the same as before.

@jinjagit jinjagit changed the title Refactor multi-clause create_delegation/1 to use all validations when attrs include participant_ids Change multi-clause create_delegation/1 to use all validations when attrs include participant_ids Oct 2, 2020
@jinjagit
Copy link
Member Author

jinjagit commented Oct 2, 2020

Sounds good. Just a quick pedantic clarification - by definition refactors don't change functionality. It's only about reorganizing code, while keeping the system working the same as before.

True. Title changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants